Commit c85b6c84 authored by Hirokazu Honda's avatar Hirokazu Honda Committed by Laurent Pinchart
Browse files

android: CameraDevice: Deny non ROTATION_0 stream configuration



libcamera doesn't handle crop_rotate_scale_degrees. Therefore,
if it is requested, that is, crop_rotate_scale_degrees is not
CAMERA3_STREAM_ROTATION_0, the configuration should fail.
Signed-off-by: default avatarHirokazu Honda <hiroh@chromium.org>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarJacopo Mondi <jacopo@jmondi.org>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
parent ac209efa
......@@ -1703,6 +1703,18 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)
if (!format.isValid())
return -EINVAL;
/* \todo Support rotation. */
if (stream->rotation != CAMERA3_STREAM_ROTATION_0) {
LOG(HAL, Error) << "Rotation is not supported";
return -EINVAL;
}
#if defined(OS_CHROMEOS)
if (stream->crop_rotate_scale_degrees != CAMERA3_STREAM_ROTATION_0) {
LOG(HAL, Error) << "Rotation is not supported";
return -EINVAL;
}
#endif
/* Defer handling of MJPEG streams until all others are known. */
if (stream->format == HAL_PIXEL_FORMAT_BLOB) {
if (jpegStream) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment