Commit 11d4e37a authored by Fabrice Bellet's avatar Fabrice Bellet Committed by Olivier Crête
Browse files

conncheck: remove a useless pair recheck

This exception to the ICE spec is no longer needed: when a pair is in
the succeeded state, there is no needed to recheck it again upon
reception of an incoming stun request on it.

Differential Revision:
parent 25b3eeec
......@@ -2820,23 +2820,6 @@ static gboolean priv_schedule_triggered_check (NiceAgent *agent, NiceStream *str
* that causes the ready -> connected transition.
priv_update_check_list_state_for_ready (agent, stream, component);
/* note: this new check is required by the new-dribble test,
* when early icheck on the peer controlled agent causes an
* incoming stun request to an already succeeded (and
* nominated) pair on the controlling agent. If the
* controlling agent doesn't retrigger a check with
* USE-CANDIDATE=1, the peer agent has no way to nominate it.
* This behavior differs from ICE spec
if ((agent->compatibility == NICE_COMPATIBILITY_RFC5245 ||
agent->compatibility == NICE_COMPATIBILITY_WLM2009 ||
agent->compatibility == NICE_COMPATIBILITY_OC2007R2) &&
agent->controlling_mode) {
priv_add_pair_to_triggered_check_queue (agent, p);
} else if (p->state == NICE_CHECK_FAILED) {
/* Triggered Checks
* If the state of the pair is Failed, it is changed to Waiting
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment