Commit 8e779dfb authored by Olivier Crête's avatar Olivier Crête
Browse files

agent: Prevent nice_agent_set_port_range() from being called after a gather

The port range is only used when gathering, print a critical if it is
called afterwards as it will have no effect.
parent d0b76154
...@@ -2411,13 +2411,19 @@ NICEAPI_EXPORT void ...@@ -2411,13 +2411,19 @@ NICEAPI_EXPORT void
nice_agent_set_port_range (NiceAgent *agent, guint stream_id, guint component_id, nice_agent_set_port_range (NiceAgent *agent, guint stream_id, guint component_id,
guint min_port, guint max_port) guint min_port, guint max_port)
{ {
Stream *stream;
Component *component; Component *component;
agent_lock(); agent_lock();
if (agent_find_component (agent, stream_id, component_id, NULL, &component)) { if (agent_find_component (agent, stream_id, component_id, &stream,
component->min_port = min_port; &component)) {
component->max_port = max_port; if (stream->gathering_started) {
g_critical ("nice_agent_gather_candidates (stream_id=%u) already called for this stream", stream_id);
} else {
component->min_port = min_port;
component->max_port = max_port;
} }
agent_unlock_and_emit (agent); agent_unlock_and_emit (agent);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment