- 15 Apr, 2014 4 commits
-
-
Philip Withnall authored
The GSource created by g_pollable_output_stream_create_source() on a NiceOutputStream would never have been dispatched, due to not having any poll events (or anything else); it only works for TCP streams because of a GCancellable child source which is triggered by the TCP code. Fix that by making ComponentSource suitable for G_IO_IN and G_IO_OUT again, and adding that as a child source for UDP output stream GSources.
-
Philip Withnall authored
-
Philip Withnall authored
At this point in the code, neither the username nor password are nul-terminated, so printing them in the debug output as nul-terminated strings can easily result in rubbish being printed after them. Fix this by specifying the string length in the printf() format string. Finally my terminal will no longer ask me to install N’Ko fonts when running the libnice tests.
-
Philip Withnall authored
If @cancellable is NULL in a call to nice_output_stream_write(), the WriteData struct is created with a reference count of 4, but only two operations are scheduled which will result in its reference count being decremented. The third operation is only scheduled if @cancellable is non-NULL (and the final reference is dropped unconditionally at the end of the function). Fix this by properly implementing reference counting for WriteData, rather than hard-coding the expected number of references in a fragile and unmaintainable way.
-
- 09 Apr, 2014 6 commits
-
-
Olivier Crête authored
Only usable with the patches from https://bugzilla.gnome.org/show_bug.cgi?id=697907
-
Philip Withnall authored
MinGW defines size_t and ssize_t for us, so we should not unconditionally redefine them in stun/win32_common.h. Add an AC_CHECK_TYPES configure check to avoid this.
-
Philip Withnall authored
Older versions of MinGW don’t define IN6_ARE_ADDR_EQUAL, as normally defined in netinet/in.h. Conditionally define it in address.c to fix the build on MinGW. MinGW has added support for the macro here: https://github.com/mirror/mingw-w64/commit/0f4899473c4ba2e34fa447b1931a04e38c1f105e Based on a patch originally by Luciana Fujii Pontello <luciana@fujii.eti.br>.
-
Olivier Crête authored
The GOutputStream based systems can sometimes call this, decide the stream is not writable and then poll for it. We have to make sure that poll is woken up.
-
Olivier Crête authored
-
Olivier Crête authored
-
- 31 Mar, 2014 20 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
This allows finding the relays asynchronously while trying to connect with other methods.
-
Olivier Crête authored
The port range is only used when gathering, print a critical if it is called afterwards as it will have no effect.
-
Olivier Crête authored
This can cause odd behaviors as it is not a idempotent function.
-
Olivier Crête authored
No behavior change is introduced
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
This can happen if a lower layer has consumed the message, bail out earlier in that case.
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
There are more than one callback that could stop it
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
Fixes off-by-one error
-
Olivier Crête authored
-
- 07 Mar, 2014 5 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
Olivier Crête authored
-
- 06 Mar, 2014 4 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
-
Philip Withnall authored
net/if_arp.h doesn’t exist on OS X, and hence causes cross-compilation to fail. It doesn’t appear to be needed for any of the functions currently used in interfaces.c anyway.
-
Philip Withnall authored
-
- 04 Mar, 2014 1 commit
-
-
Philip Withnall authored
If we emit signals from component_io_cb() in the middle of a read, it’s possible that one of those signals will be picked up by the client to perform another read. A likely candidate (and what was triggering the re-entrancy here) would be component-state-changed. Since signals are emitted synchronously, the second read would being inside the first, and trigger the anti-re-entrancy assertion.
-