Otherwise, the caller gets a callback from an unexpected source.

Philip Withnall authored Jul 04, 2014 and Olivier Crête committed Jul 07, 2014

The old GetIpAddrTable() function only returned IPv4 addresses. In order
to support IPv6 addresses, we need to use GetAdapterAddresses(), which
is available from Windows XP or Server 2003 onwards.

Philip Withnall authored Jul 04, 2014 and Olivier Crête committed Jul 07, 2014

Rather than using inet_pton(), which doesn’t support IPv6 link-local
scope IDs, use getaddrinfo(). This is supported on all platforms
(POSIX.1-2001, and Windows winsock).

Philip Withnall authored Jul 04, 2014 and Olivier Crête committed Jul 07, 2014

inet_ntop() drops IPv6 link-local scope IDs on the floor, which means
libnice doesn’t generate any IPv6 candidates for link-local connections,
meaning that it will theoretically fail to negotiate a connection on an
IPv6-only network where the two peers are local.

Fix that by using getnameinfo() to convert sockaddrs to strings, which
preserves the scope ID.

There are no portability concerns — getnameinfo() is POSIX.1-2001, and
isn’t used on Windows (although it is supported, surprisingly).

Otherwise we're never woken up when it's again possible to send

Philip Withnall authored Jul 02, 2014 and Olivier Crête committed Jul 07, 2014

If (agent->main_context == NULL) the sockets are created with a NULL
main context, which they then try to ref. That does not end well.

Philip Withnall authored Jun 30, 2014 and Olivier Crête committed Jul 07, 2014

We know the agent is a GObject — there is no need to check it at
runtime. This also improves Tartan’s static analysis of signal
connections.

Philip Withnall authored Jun 30, 2014 and Olivier Crête committed Jul 07, 2014

Spotted by Tartan.

Philip Withnall authored Jun 30, 2014 and Olivier Crête committed Jul 07, 2014

This removes it from the introspected bindings. It is unintrospectable
because it specifies a callback (@func) which persists after the
nice_agent_attach_recv() call returns. This is only supported by
gobject-introspection if a full closure with GDestroyNotify callback for
the user is passed in too.

Philip Withnall authored Jun 30, 2014 and Olivier Crête committed Jul 07, 2014

These make the GSLists usable from introspection.

Philip Withnall authored Jun 30, 2014 and Olivier Crête committed Jul 07, 2014

This bumps our autoconf requirement to 2.62 (from 2.59c) and disables
automake portability warnings.

It does not introduce a hard dependency on gobject-introspection; but if
available, it requires version 1.30.0. Support can be enabled with
--enable-introspection, and is required to make distcheck.

The generated introspection file has not been checked thoroughly, and
may expose internal symbols. A lot of new annotations are needed to make
many of the symbols usable.

Philip Withnall authored Jun 30, 2014 and Olivier Crête committed Jul 07, 2014

It might be useful for dependent packages to check whether libnice was
compiled with UPnP support, so expose that as a variable in the
pkg-config file, set to ‘true’ if supported, and the empty string
otherwise.

Philip Withnall authored Jun 30, 2014 and Olivier Crête committed Jul 07, 2014

The requirements in the pkg-config file were outdated and incomplete. It
makes a lot more sense to automatically substitute them in from the
checks in configure.ac.

We use macros from 1.12 anyway.

We want ICE-TCP to not have reliable behavior unless the agent
is reliable otherwise it will confuse existing VoIP applications.

PseudoTCP is only used if both the pseudotcp socket exists and the
underlying transport is unreliable.

discovery: Make it less likely that a locally assigned remote foundation clashes with the remote one.

The RFC says that "for reflexive and relayed candidates, the STUN or TURN servers
used to obtain them have the same IP address."

This signal include the whole candidate as the foundation is ambiguous.

These signals include the actual candidate instead of just the foundation
which is not unique.