GitLab

Fabrice Bellet authored May 19, 2019 and Olivier Crête committed Jul 04, 2019

The patch makes the agent alive at least until the last callback of
the removal of turn refreshes when a stream is deleted from the agent.

Closes #84

Fabrice Bellet authored Jun 09, 2019 and Olivier Crête committed Jul 04, 2019

The base64 decoded username and password strings given to
stun_usage_turn_create() should not freed immediately, since they remain
used when handling the following related inbound stun replies.

The automake generated ones are a little funky, so the meson one have to also be
to not break API...

This API makes it possible to get an array of all of the sockets used
by a specific component, this is useful to set options on the socket.

Also bump GLib requirement to 2.54, which is the version in RHEL 7

By default libnice now ignores network interfaces from virtual machines
and containers, i.e. names that start with "docker", "veth", "virbr" and
"vnet".

If you want to disable this feature override the default with

       ./configure --without-ignored-network-interface-prefix ...
       ./configure --with-ignored-network-interface-prefix= ...
       meson setup -D ignored-network-interface-prefix= ...
       meson setup -D ignored-network-interface-prefix=[] ...

This fixes commit b4abda09

--without-XXX sets $withval to "no", hence we must check for this special
value instead of ignoring network interfaces that start with "no".

The parameter for the ignored network interface prefix build option
accepts a comma-separated string now. This list will be converted to a
comma-separated list of string literals for the C code.

Disable the feature:

   ./configure ...
   ./configure --with-ignored-network-interface-prefix= ...
   meson setup -D ignored-network-interface-prefix= ...
   meson setup -D ignored-network-interface-prefix=[] ...

Ignore interfaces whose names start with "virbr":

   ./configure --with-ignored-network-interface-prefix=virbr ...
   meson setup -D ignored-network-interface-prefix=virbr ...

Ignore interfaces whose names start with "virbr" or "veth":

   ./configure --with-ignored-network-interface-prefix=virbr,veth ...
   meson setup -D ignored-network-interface-prefix=virbr,veth ...

Improve on commit b4abda09

Instead of checking one prefix, check against a list of prefixes. This
allows libnice to be configured to ignore interfaces from virtual
machines and containers.

Check for IFF_UP and IFF_RUNNING flags on the interface.

This fixes commit 9afd0c8b

Update nice_interfaces_is_private_ip() to handle IPv6 too:

- unique local address block: fc00::/7
- link-local address block:   fe80::/10

This fixes commit b4abda09

Copy the implementation to the !HAVE_GETIFADDRS branch too.

Clone implementation from HAVE_GETIFADDRS branch to !HAVE_GETIFADDRS
branch of nice_interfaces_get_local_ips()

Fix regression introduced by https://gitlab.freedesktop.org/libnice/libnice/commit/da41258a21102f63ec5d5b2dc20d303f772eb195. Fix #64.

Code comment mentions peer reflexive candidate pair should be selected
only in the case of TCP local candidates, but it was done in all cases.

Otherwise, MSVC will complain and cause build error.

This makes the API more GIO style

Asynchronously closes resources the agent has allocated on remote
servers.

When deleting a turn refresh, ensure the assocaited port allocations on
the TURN server are properly removed. This means wait for a response for
our 0-lifetime refresh request and implement retransmissions. Only
delete the refresh after TURN port removal has been confirmed or all
our retransmissions timed out.

First collect the relay candidates, then dispose them in a loop.

Andrey Skryabin authored Nov 06, 2018 and Olivier Crête committed May 08, 2019

Attribute is proposed here: https://tools.ietf.org/html/draft-thatcher-ice-renomination-00
WebRTC supports this attribute: controlling side provides attribute value increased by one each time selected pair is changed:
https://chromium.googlesource.com/external/webrtc/+/3c7d599750405bc734e1d5adbf1b54265b725a9d/p2p/base/p2ptransportchannel.cc#1821

conn_check_prune_socket() was trying to access deleted NiceCandidate
instance. Prune the socket before removing the candidate.

Closes #73

Call nice_agent_peer_candidate_gathering_done () where appropriate.

The STUN thread may be blocked waiting for stun_signal_ptr so signal it
when stopping the thread.

In this mode, activated by setting "ice-trickle" property of a
NiceAgent to TRUE, a component without a successful connectivity check
will wait indefinitely for more remote candidates to come.

nice_agent_peer_candidate_gathering_done() must be called after
receiving the last remote candidate for the component to finally change
its state to NICE_COMPONENT_STATE_FAILED.

Windows users should just use Meson for building libnice.