GitLab

Instead of just blindling assuming that all of the pointers are valid
until the end.

It can now take it from the agent.

Nice to make debug logs more friendly to read.

If the error handling block in the middle of the recv() loop is hit,
various things were previously leaked (context, cancellable_source) and
the return values were potentially incorrect.

Fix the break out of the error handling block to clean up correctly.

So use guint64 everywhere, this is never supposed to be negative.

This allows finding the relays asynchronously while trying to connect
with other methods.

The port range is only used when gathering, print a critical if it is
called afterwards as it will have no effect.

This can cause odd behaviors as it is not a idempotent function.

No behavior change is introduced

This can happen if a lower layer has consumed the message, bail out earlier in
that case.

Fixes off-by-one error

Note that it’s a new _local_ candidate.

If we emit signals from component_io_cb() in the middle of a read, it’s
possible that one of those signals will be picked up by the client to
perform another read. A likely candidate (and what was triggering the
re-entrancy here) would be component-state-changed. Since signals are
emitted synchronously, the second read would being inside the first, and
trigger the anti-re-entrancy assertion.

This way, there can be no annoying re-entrancy in our code.

This should prevent us from re-adding re-entrancy in the future

This way, there can be no annoying re-entrancy in our code.

Ensure the agent’s context doesn’t get iterated while in the middle of
reading a message, as that will corrupt the component->recv_messages
state.

Use it instead of memcmp() to avoid comparing padding bytes.

And we get close to 10% perf boost