GitLab

RFC 5389 says:
   All STUN messages sent over UDP SHOULD be less than the path MTU, if
   known.  If the path MTU is unknown, messages SHOULD be the smaller of
   576 bytes and the first-hop MTU for IPv4 [RFC1122] and 1280 bytes for
   IPv6 [RFC2460].

So sending 65536 bytes is always wrong

The GSource created by g_pollable_output_stream_create_source() on a
NiceOutputStream would never have been dispatched, due to not having any
poll events (or anything else); it only works for TCP streams because of
a GCancellable child source which is triggered by the TCP code.

Fix that by making ComponentSource suitable for G_IO_IN and G_IO_OUT
again, and adding that as a child source for UDP output stream GSources.

Only usable with the patches from
https://bugzilla.gnome.org/show_bug.cgi?id=697907

When using optimal path where recv message has only one buffer, the
buffer length was set to the size of the buffer, not its length, which was
causing the wrong message length to be returned causing the agent to
discard STUN messages because their size doesn't match received data
length.

This introduces no functional changes, but consolidates and documents
the code a bit more.

Use a NULL check to determine if upnp_mapping is an empty list (rather
than counting every element). Use g_slist_free_full() where appropriate.

This introduces no functional changes.

It’s in milliseconds.

The test for fe80::/10 always returned FALSE.

But keep the turn connection that's currently being used if it is
the selected candidate. Also clear the TURN candidate refresh.

Instead of just blindling assuming that all of the pointers are valid
until the end.

Change the SocketSource handling to make it possible
to remove a source, not only to add one.

It can now take it from the agent.

Skips one iterator over g_slist_foreach() + g_slist_free(). It is also easier
to read.

It is never used outside of this file.

If doing a recv on UDP-TURN, the 'from' address was kept set to
the turn server which causes connchecks to fail with "mismatched address"
error. This fixes it