- 14 Dec, 2018 8 commits
-
-
Víctor Manuel Jáquez Leal authored
-
Tim-Philipp Müller authored
-
Tim-Philipp Müller authored
It's not a requirement, there's a fallback.
-
Tim-Philipp Müller authored
-
Tim-Philipp Müller authored
-
Tim-Philipp Müller authored
-
Tim-Philipp Müller authored
-
Jakub Adam authored
The streams are matched by the order in which they appear in the SDP, not by name, so insisting on local streams to have one makes no sense. This likely should have been removed in 5972db04.
-
- 21 Nov, 2018 1 commit
-
-
Olivier Crête authored
If this isn't done, then there may be invalid points left inside the passive socket which could be used and cause a crash. Fixes #33
-
- 20 Nov, 2018 1 commit
-
-
Jakub Adam authored
Avoids race between socket_send_more() and socket_close() leading either to crash on use of freed NiceSocket, or abort upon attempting to g_mutex_clear() a locked mutex. Akin to what d1611c0c did to udp-turn.
-
- 19 Nov, 2018 1 commit
-
-
Olivier Crête authored
To be able to call it from a context that is already locked.
-
- 16 Nov, 2018 1 commit
-
-
Olivier Crête authored
-
- 31 Oct, 2018 4 commits
-
-
Jakub Adam authored
nice_socket_recv_messages() may return a NiceInputMessage of length = 0, so before attempting to read the RFC4571 header check the message really has at least sizeof (guint16) bytes of data. The bug's always been there, the previous commit only made it more apparent.
-
Jakub Adam authored
There might be multiple RFC4571-framed messages (or fragments thereof) within a single TCP-TURN message. Make sure each NiceInputMessage passed by the user into socket_recv_messages() gets exactly one RFC4571 frame, or remains empty if there aren't any messages to receive. We should keep any data that doesn't fit into the user buffers for the next time socket_recv_messages() gets called with the socket.
-
Jakub Adam authored
After being parsed, a TURN control message turns into a NiceInputMessage with zero length. Such message doesn't increment the iteration counter i and so is re-processed in the next iteration, which detects right away that message->length == 0 and continues to the next element in recv_messages. Thus, n_valid_messages variable serves no real purpose and to achieve the same result we can simply increment the iteration counter after each message.
-
Olivier Crête authored
-
- 28 Oct, 2018 7 commits
-
-
Olivier Crête authored
The socket abstraction not being reference counted, we need a global lock for them in the short term.
-
Olivier Crête authored
It's not locked in any way.
-
Olivier Crête authored
-
Olivier Crête authored
This should make it safer.
-
Olivier Crête authored
-
Olivier Crête authored
Remove all pointers that don't include have a reference except to agents
-
Juan Navarro authored
Work on libnice's bug #1 in Gitlab. This work is composed of multiple merged parts: - "Global lock contention removed" Phabricator D1900: https://phabricator.freedesktop.org/D1900 By @nifigase Opened in GitLab as Merge Request !12 - "agent: properly handle NiceAgent ref in callbacks from timeout sources" Phabricator D1898: https://phabricator.freedesktop.org/D1898 By @mparis This patch was itself based upon a previous version of the work done in D1900. After the switch of hosting, it got lost. On top of these, additions to follow some review comments from @ocrete: - https://phabricator.freedesktop.org/D1900#40412 - https://phabricator.freedesktop.org/D1898#39332
-
- 21 Oct, 2018 10 commits
-
-
Olivier Crête authored
-
Matthew Waters authored
getifaddrs() may only be available if the target API is >= 24
-
Michael Olbrich authored
This makes it possible to enable keepalive for TCP candidates. It is useful to detect disappearing peers or network failures faster.
-
Michael Olbrich authored
By default, 'candidate_identifier == NULL' only happens for 'compatibility == NICE_COMPATIBILITY_GOOGLE'. However, keepalive=true will also trigger the same code path so candidate_identifier must be checked to avoid a segfault.
-
Michael Olbrich authored
For some connection types nicesock->fileno is never set. Make sure it is not NULL before using it.
-
Olivier Crête authored
-
Brendan Shanks authored
-
Brendan Shanks authored
-
Brendan Shanks authored
-
Olivier Crête authored
-
- 21 Jun, 2018 1 commit
-
-
Olivier Crête authored
-
- 19 Jun, 2018 2 commits
-
-
Olivier Crête authored
-
Olivier Crête authored
-
- 18 Jun, 2018 3 commits
-
-
Olivier Crête authored
Now, we use GitLab at https://gitlab.freedesktop.org/libnice/libnice
-
Justin Kim authored
MacOS X and Windows don't have MSG_NOSIGNAL. Signed-off-by:
Justin Kim <justin.kim@collabora.com>
-
Nicolas Dufresne authored
There was two cases where instead of freeing the queue, we actually clear the queue so it's ready for reused. Notably in nice_socket_free_send_queue(), a missed name function and nicesrc element state change. This regression was introduced by: fa783b1dd727a6ee2b99a111ca24790ae850c2f7
-
- 12 Jun, 2018 1 commit
-
-
Nicolas Dufresne authored
This is new warning introduced with GCC 8. This is being fixed by using appropriate function, like g_queue_free_full/g_list_free_full or by casting to GCallback before casting to the target function signature. Closes: #46
-