Skip to content
  • Jakub Adam's avatar
    ms-turn: don't wait for a reply to STUN_SEND request · d8cdbd70
    Jakub Adam authored and Olivier Crête's avatar Olivier Crête committed
    As per [MS-TURN] Section 2.2.1, TURN message type 0x0104 "Send request
    response" isn't supported and the TURN server MUST NOT send them. Thus,
    libnice should not remember Send requests in agent->sent_ids because
    without replies coming, the number of allowed pending transaction gets
    quickly exhausted, causing our data packets to be dropped until a
    request timeout frees some space in the queue.
    
    This behavior resulted in choppy reception of our audio on a Lync client
    when connected via Lync Edge (TURN) Server.
    
    Maniphest Tasks: T126
    
    Reviewers: pwithnall
    
    Projects: #libnice
    
    Reviewed By: pwithnall
    
    Subscribers: pwithnall
    
    Differential Revision: https://phabricator.freedesktop.org/D223
    d8cdbd70