1. 09 Oct, 2014 18 commits
  2. 08 Oct, 2014 1 commit
  3. 26 Sep, 2014 3 commits
  4. 25 Sep, 2014 8 commits
  5. 24 Sep, 2014 1 commit
  6. 23 Sep, 2014 5 commits
  7. 22 Sep, 2014 4 commits
    • Olivier Crête's avatar
      agent: Clear GSource timeout also for GUPnP timeout · 685cf0b4
      Olivier Crête authored
      Fix regressions introduced by the following patch:
      Clear existing GSource timeouts before adding new ones
      685cf0b4
    • Philip Withnall's avatar
      agent: Drop valid but unmatched STUN packets · b98b98ad
      Philip Withnall authored
      Rather than passing them through to the application. Invalid STUN
      packets are still passed through, but it causes unnecessary noise and
      corruption for higher-level applications to receive STUN packets they
      weren’t expecting.
      
      This is permitted by RFC 5389, §7.3.0:
          If any errors are detected, the message is silently discarded.
          In the case when STUN is being multiplexed with another protocol,
          an error may indicate that this is not really a STUN message; in
          this case, the agent should try to parse the message as a different
          protocol.
      where I interpret ‘error’ to mean ‘validation error’ rather than (e.g.)
      ‘unrecognised attribute’ or ‘unmatched response’ where the STUN packet
      is otherwise perfectly formed.
      b98b98ad
    • Philip Withnall's avatar
      agent: Remove dangling pointers on NiceSocket destruction · f6337b53
      Philip Withnall authored
      If a NiceSocket is destroyed, various pointers are currently left
      dangling to it in the conncheck state. These can cause crashes if (for
      example) a CandidateCheckPair with such a dangling pointer is then used;
      the GSocket methods will fail.
      
      Fix this by explicitly removing the socket and all NiceCandidates which
      wrap it from various areas of the state.
      f6337b53
    • Philip Withnall's avatar
      agent: Factor out state transition to FAILED for CandidateCheckPairs · 6c8856bb
      Philip Withnall authored
      This introduces no functional changes.
      6c8856bb