Skip to content
  • epriestley's avatar
    In "arc diff", warn when some reviewers are away even if not everyone is away · 07a208d8
    epriestley authored
    Summary:
    Ref T13249. See PHI810. We currently warn you when //all// reviewers are away, but not when only some reviewers are away.
    
    This makes some amount of sense under the "anyone can accept anything" rules we sort of recommend, but a lot of installs realistically have tons of owner/package rules now.
    
    Instead, if any reviewers are away, show the user exactly who is away and until when, then make sure they don't want to make any adjustments.
    
    (We can do a better job of this after the toolsets change when we can use the new APIs, but this is an easy fix for now.)
    
    Test Plan: Created a revision with multiple reviewers, either some or all of whom were away. Got appropriate output and prompt behavior.
    
    Reviewers: amckinley
    
    Reviewed By: amckinley
    
    Maniphest Tasks: T13249
    
    Differential Revision: https://secure.phabricator.com/D20172
    07a208d8