Commit fceac878 authored by Joshua Spence's avatar Joshua Spence

Allow `setCustomSeverityRules` to be overridden in subclasses

I am writing a proxy linter that can be used to wrap any `ArcanistExternalLinter` and execute all commands within a Docker container (see [[ |`ArcanistDockerContainerLinterProxy`]] from [[ | `flarc`]]). In order for `ArcanistDockerContainerLinterProxy` to behave like the `ArcanistExternalLinter` that is being proxied, `final` needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change ({D19630}) was previously accepted.

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision:
parent 4f583dde
......@@ -214,9 +214,6 @@ abstract class ArcanistLinter extends Phobject {
return 1.0;
* TODO: This should be `final`.
public function setCustomSeverityMap(array $map) {
$this->customSeverityMap = $map;
return $this;
......@@ -227,7 +224,7 @@ abstract class ArcanistLinter extends Phobject {
return $this;
final public function setCustomSeverityRules(array $rules) {
public function setCustomSeverityRules(array $rules) {
$this->customSeverityRules = $rules;
return $this;
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment