Update for Maniphest modular transactions

Signed-off-by: Daniel Stone <daniels@collabora.com>

src/conduit/SprintManiphestConduitAPIMethod.php

@@ -61,7 +61,7 @@ abstract class SprintManiphestConduitAPIMethod extends ConduitAPIMethod {
     if ($is_new) {
       $task->setTitle((string)$request->getValue('title'));
       $task->setDescription((string)$request->getValue('description'));
-      $changes[ManiphestTransaction::TYPE_STATUS] =
+      $changes[ManiphestTaskStatusTransaction::TRANSACTIONTYPE] =
           ManiphestTaskStatus::getDefaultStatus();
       $changes[PhabricatorTransactions::TYPE_SUBSCRIBERS] =
           array('+' => array($request->getUser()->getPHID()));
@@ -74,12 +74,12 @@ abstract class SprintManiphestConduitAPIMethod extends ConduitAPIMethod {
 
       $title = $request->getValue('title');
       if ($title !== null) {
-        $changes[ManiphestTransaction::TYPE_TITLE] = $title;
+        $changes[ManiphestTaskTitleTransaction::TRANSACTIONTYPE] = $title;
       }
 
       $desc = $request->getValue('description');
       if ($desc !== null) {
-        $changes[ManiphestTransaction::TYPE_DESCRIPTION] = $desc;
+        $changes[ManiphestTaskDescriptionTransaction::TRANSACTIONTYPE] = $desc;
       }
 
       $status = $request->getValue('status');
@@ -89,7 +89,7 @@ abstract class SprintManiphestConduitAPIMethod extends ConduitAPIMethod {
           throw id(new ConduitException('ERR-INVALID-PARAMETER'))
               ->setErrorDescription(pht('Status set to invalid value.'));
         }
-        $changes[ManiphestTransaction::TYPE_STATUS] = $status;
+        $changes[ManiphestTaskStatusTransaction::TRANSACTIONTYPE] = $status;
       }
     }
 
@@ -100,7 +100,7 @@ abstract class SprintManiphestConduitAPIMethod extends ConduitAPIMethod {
         throw id(new ConduitException('ERR-INVALID-PARAMETER'))
             ->setErrorDescription(pht('Priority set to invalid value.'));
       }
-      $changes[ManiphestTransaction::TYPE_PRIORITY] = $priority;
+      $changes[ManiphestTaskPriorityTransaction::TRANSACTIONTYPE] = $priority;
     }
 
     $owner_phid = $request->getValue('ownerPHID');
@@ -109,7 +109,7 @@ abstract class SprintManiphestConduitAPIMethod extends ConduitAPIMethod {
           array($owner_phid),
           PhabricatorPeopleUserPHIDType::TYPECONST,
           'ownerPHID');
-      $changes[ManiphestTransaction::TYPE_OWNER] = $owner_phid;
+      $changes[ManiphestTaskOwnerTransaction::TRANSACTIONTYPE] = $owner_phid;
     }
 
     $ccs = $request->getValue('ccPHIDs');

src/query/SprintQuery.php

@@ -304,7 +304,8 @@ final class SprintQuery extends SprintDAO {
   }
 
   public function extractEvents($xactions) {
-    assert_instances_of($xactions, 'ManiphestTransaction');
+    // Maniphest transactions are now modular ...
+    //assert_instances_of($xactions, 'ManiphestTransaction');
 
     $events = array();
     foreach ($xactions as $xaction) {

src/storage/BoardDataProvider.php

@@ -168,7 +168,7 @@ final class BoardDataProvider {
     $scope_phid = $this->project->getPHID();
     $task_phids = mpull($this->tasks, 'getPHID');
     $query = new ManiphestTransactionQuery();
-    $query->withTransactionTypes(array(ManiphestTransaction::TYPE_STATUS));
+    $query->withTransactionTypes(array(ManiphestTaskStatusTransaction::TRANSACTIONTYPE));
     $query->withObjectPHIDs($task_phids);
     $query->setViewer($this->viewer);
     $stories = $query->execute();

src/storage/SprintColumnTransaction.php

@@ -116,7 +116,7 @@ final class SprintColumnTransaction {
   }
 
   public function setEventsTaskStatus($xactions) {
-    assert_instances_of($xactions, 'ManiphestTransaction');
+    //assert_instances_of($xactions, 'ManiphestTransaction');
     $events = array();
     foreach ($xactions as $xaction) {
       if ($xaction->getOldValue() == null) {

src/view/reports/SprintReportBurnUpView.php

@@ -32,7 +32,7 @@ final class SprintReportBurnUpView extends SprintView {
   private function getXactionData($project_phid) {
      $query = id(new SprintQuery())
         ->setPHID($project_phid);
-      $data = $query->getXactionData(ManiphestTransaction::TYPE_STATUS);
+      $data = $query->getXactionData(ManiphestTaskStatusTransaction::TRANSACTIONTYPE);
     return $data;
   }