Commit 43a8d876 authored by epriestley's avatar epriestley
Browse files

Update out-of-date API calls when rendering diffs inline in email

Summary: See PHI1745. This callsite for "ChangesetParser" was not properly updated for recent changes.

Test Plan:
  - Set `metamta.differential.inline-patches` to 100.
  - Created a new revision with a small (<100 line) diff, with at least one reviewer.
  - Ran `bin/phd debug` and observed outbound mail queue with `bin/mail list-outbound`.
  - Before: fatal when trying to generate the inline changes for mail.
  - After: clean mail generation.

Differential Revision: https://secure.phabricator.com/D21270
parent 86d6abe9
......@@ -40,11 +40,13 @@ final class DifferentialChangeDetailMailView
$diff = $this->getDiff();
$engine = new PhabricatorMarkupEngine();
$viewstate = new PhabricatorChangesetViewState();
$out = array();
foreach ($diff->getChangesets() as $changeset) {
$parser = id(new DifferentialChangesetParser())
->setUser($viewer)
->setViewer($viewer)
->setViewState($viewstate)
->setChangeset($changeset)
->setLinesOfContext(2)
->setMarkupEngine($engine);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment