LOCAL: Validate variables before calling functions

Some customization are not being used in Phabricator Apertis
instance. So some features were breaking when calling functions
in variables that were null

src/applications/maniphest/editor/ManiphestTransactionEditor.php

@@ -363,7 +363,10 @@ final class ManiphestTransactionEditor
     array $xactions) {
 
     $this->setContinueOnNoEffect(true);
-    $snipe_api = new SnipeItHelper();
+
+    if (class_exists('SnipeItHelper')) {
+      $snipe_api = new SnipeItHelper();
+    }
 
     $actor = $this->getActor();
     $actor_phid = $actor->getPHID();

src/applications/policy/filter/PhabricatorPolicyFilter.php

@@ -939,8 +939,9 @@ final class PhabricatorPolicyFilter extends Phobject {
     }
 
     // See long comment in PhabricatorCursorPagedPolicyAwareQuery
-    if ($space->getPHID() == PhabricatorSpacesNamespaceQuery::getMagicAllUsersSpace()->getPHID()) {
-      return true;
+    if(PhabricatorSpacesNamespaceQuery::getMagicAllUsersSpace() &&
+      $space->getPHID() == PhabricatorSpacesNamespaceQuery::getMagicAllUsersSpace()->getPHID()) {
+        return true;
     }
 
     // This may be more involved later, but for now being able to see the

src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php

@@ -102,7 +102,10 @@ final class PhabricatorSpacesNamespaceQuery
     // exist.
     $spaces = self::getViewerSpaces($viewer);
 
-    unset($spaces[self::getMagicAllUsersSpace()->getPHID()]);
+    if (self::getMagicAllUsersSpace()) {
+      unset($spaces[self::getMagicAllUsersSpace()->getPHID()]);
+    }
+
     return (count($spaces) > 1);
   }
 

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

@@ -3197,10 +3197,11 @@ abstract class PhabricatorCursorPagedPolicyAwareQuery
       //
       // Modifying this code is not recommended.
       $result_object_interface = $this->newResultObject();
-      if ($result_object_interface instanceof PhrictionContent ||
-          $result_object_interface instanceof PhrictionDocument) {
+      if (PhabricatorSpacesNamespaceQuery::getMagicAllUsersSpace() &&
+          ($result_object_interface instanceof PhrictionContent ||
+           $result_object_interface instanceof PhrictionDocument)) {
         $all_user_space = PhabricatorSpacesNamespaceQuery::getMagicAllUsersSpace();
-	$space_phids[$all_user_space->getPHID()] = $all_user_space->getPHID();
+        $space_phids[$all_user_space->getPHID()] = $all_user_space->getPHID();
       }
     }