Commit e46e383b authored by epriestley's avatar epriestley
Browse files

Clean up "Revisions/Commits" table in Maniphest slightly

Summary: Ref T13440. Give the table more obvious visual structure and get rid of the largely useless header columns.

Test Plan: Viewed table, saw a slightly cleaner result.

Maniphest Tasks: T13440

Differential Revision: https://secure.phabricator.com/D20885
parent c48f300e
......@@ -9,7 +9,7 @@ return array(
'names' => array(
'conpherence.pkg.css' => '3c8a0668',
'conpherence.pkg.js' => '020aebcf',
'core.pkg.css' => '9a391b14',
'core.pkg.css' => '77de226f',
'core.pkg.js' => '6e5c894f',
'differential.pkg.css' => '607c84be',
'differential.pkg.js' => '1b97518d',
......@@ -30,7 +30,7 @@ return array(
'rsrc/css/aphront/notification.css' => '30240bd2',
'rsrc/css/aphront/panel-view.css' => '46923d46',
'rsrc/css/aphront/phabricator-nav-view.css' => 'f8a0c1bf',
'rsrc/css/aphront/table-view.css' => '061e45eb',
'rsrc/css/aphront/table-view.css' => '0bb61df1',
'rsrc/css/aphront/tokenizer.css' => 'b52d0668',
'rsrc/css/aphront/tooltip.css' => 'e3f2412f',
'rsrc/css/aphront/typeahead-browse.css' => 'b7ed02d2',
......@@ -535,7 +535,7 @@ return array(
'aphront-list-filter-view-css' => 'feb64255',
'aphront-multi-column-view-css' => 'fbc00ba3',
'aphront-panel-view-css' => '46923d46',
'aphront-table-view-css' => '061e45eb',
'aphront-table-view-css' => '0bb61df1',
'aphront-tokenizer-control-css' => 'b52d0668',
'aphront-tooltip-css' => 'e3f2412f',
'aphront-typeahead-control-css' => '8779483d',
......
......@@ -593,6 +593,7 @@ final class ManiphestTaskDetailController extends ManiphestController {
$handle_phids = array();
$any_linked = false;
$any_status = false;
$idx = 0;
$objects = array();
......@@ -623,7 +624,6 @@ final class ManiphestTaskDetailController extends ManiphestController {
->setIcon($status->getIcon())
->setColor($status->getColor())
->setName($status->getName());
}
}
......@@ -750,9 +750,9 @@ final class ManiphestTaskDetailController extends ManiphestController {
if ($repository_phid !== $last_repository) {
$repository_link = null;
if ($repository_phid) {
$repository_link = $handles[$repository_phid]->renderLink();
$repository_handle = $handles[$repository_phid];
$rows[] = array(
$repository_link,
$repository_handle->renderLink(),
);
$rowd[] = true;
}
......@@ -772,6 +772,9 @@ final class ManiphestTaskDetailController extends ManiphestController {
->setIcon($handle->getIcon());
$status_view = $object['status'];
if ($status_view) {
$any_status = true;
}
$revision_tags = array();
foreach ($object['revisionPHIDs'] as $link_phid) {
......@@ -797,16 +800,9 @@ final class ManiphestTaskDetailController extends ManiphestController {
$changes_table = id(new AphrontTableView($rows))
->setNoDataString(pht('This task has no related commits or revisions.'))
->setRowDividers($rowd)
->setHeaders(
array(
null,
null,
null,
pht('Revision/Commit'),
))
->setColumnClasses(
array(
'center',
'indent center',
null,
null,
'wide pri object-link',
......@@ -814,14 +810,14 @@ final class ManiphestTaskDetailController extends ManiphestController {
->setColumnVisibility(
array(
true,
true,
$any_status,
$any_linked,
true,
))
->setDeviceVisibility(
array(
false,
true,
$any_status,
false,
true,
));
......
......@@ -306,7 +306,7 @@ final class AphrontTableView extends AphrontView {
'td',
array(
'class' => 'row-divider',
'colspan' => count($headers),
'colspan' => count($visibility),
),
$value);
$row_idx = -1;
......
......@@ -61,6 +61,10 @@
padding: 8px 12px;
}
.aphront-table-view td.indent {
padding-left: 24px;
}
.aphront-table-view th {
border-bottom: 1px solid {$thinblueborder};
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment