Commit fa756098 authored by Daniel Stone's avatar Daniel Stone Committed by Ana Rute Mendes
Browse files

LOCAL/UI: Maniphest: Show points and review status in task queries

In the Maniphest query result view, show the story points as well as the
review/CI status on each task as we currently show them in workboard
column cards, along with the project tags.

This is local UI policy; the correct fix (of rewriting hover/card views
to be more generic and extensible) is pretty much impossible to achieve,
and isn't approachable by non-Phacility contributors.
parent 4dcef812
...@@ -107,6 +107,28 @@ final class ManiphestTaskListView extends ManiphestView { ...@@ -107,6 +107,28 @@ final class ManiphestTaskListView extends ManiphestView {
$item->addAttribute($subtype_tag); $item->addAttribute($subtype_tag);
} }
$review_status = $task->getReviewIcon($this->getUser());
if ($review_status !== null) {
$item->addAttribute(
id(new PHUITagView())
->setType(PHUITagView::TYPE_OBJECT)
->setBackgroundColor(null)
->setIcon($review_status));
}
if (ManiphestTaskPoints::getIsEnabled()) {
$points = $task->getPoints();
if ($points !== null) {
$item->addAttribute(
id(new PHUITagView())
->setType(PHUITagView::TYPE_SHADE)
->setColor(PHUITagView::COLOR_GREY)
->setSlimShady(true)
->setName($points)
->addClass('phui-workcard-points'));
}
}
$project_handles = array_select_keys( $project_handles = array_select_keys(
$handles, $handles,
array_reverse($task->getProjectPHIDs())); array_reverse($task->getProjectPHIDs()));
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment