- 30 May, 2020 1 commit
-
-
epriestley authored
-
- 26 May, 2020 2 commits
-
-
epriestley authored
Summary: Currently, Phortune attempts to prevent users from removing themselves as account managers. It does this by checking that the new list includes them. Usually this is sufficient, because you can't normally edit an account unless you're already a manager. However, we get the wrong result (incorrect rejection of the edit) if the actor is omnipotent and the acting user was not already a member. It's okay to edit an account into a state which doesn't include you if you have permission to edit the account and aren't already a manager. Specifically, this supports more formal tooling around staff modifications to billing accounts, where the actor has staff-omnipotence and the acting user is a staff member and only used for purposes of leaving a useful audit trail. Test Plan: Elsewhere, ran staff tooling to modify accounts and was able to act as "alice" to add "bailey", even though "alice" was not herself a manager. Differential Revision: https://secure.phabricator.com/D21288
-
epriestley authored
Summary: Currently, Phortune attempts to prevent users from removing themselves as account managers. It does this by checking that the new list includes them. Usually this is sufficient, because you can't normally edit an account unless you're already a manager. However, we get the wrong result (incorrect rejection of the edit) if the actor is omnipotent and the acting user was not already a member. It's okay to edit an account into a state which doesn't include you if you have permission to edit the account and aren't already a manager. Specifically, this supports more formal tooling around staff modifications to billing accounts, where the actor has staff-omnipotence and the acting user is a staff member and only used for purposes of leaving a useful audit trail. Test Plan: Elsewhere, ran staff tooling to modify accounts and was able to act as "alice" to add "bailey", even though "alice" was not herself a manager. Differential Revision: https://secure.phabricator.com/D21288
-
- 23 May, 2020 2 commits
-
-
epriestley authored
Summary: Ref T13513. An inline is not considered empty if it has a suggestion, but some of the shared transaction code doesn't test for this properly. Update the shared transaction code to be aware that application comments may have more complex emptiness rules. Test Plan: - Posted an inline with only an edit suggestion, comment went through. - Tried to post a normal empty comment, got an appropriate warning. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21287
-
epriestley authored
Summary: Ref T13513. An inline is not considered empty if it has a suggestion, but some of the shared transaction code doesn't test for this properly. Update the shared transaction code to be aware that application comments may have more complex emptiness rules. Test Plan: - Posted an inline with only an edit suggestion, comment went through. - Tried to post a normal empty comment, got an appropriate warning. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21287
-
- 22 May, 2020 6 commits
-
-
epriestley authored
Summary: See PHI1753. This condition got rewritten for suggested edits and accidentally inverted. Test Plan: - Create a comment, type text, save draft, edit comment, cancel. - Before: comment hides itself. - After: comment properly cancels into pre-edit draft state. Differential Revision: https://secure.phabricator.com/D21286
-
epriestley authored
Summary: See PHI1753. This condition got rewritten for suggested edits and accidentally inverted. Test Plan: - Create a comment, type text, save draft, edit comment, cancel. - Before: comment hides itself. - After: comment properly cancels into pre-edit draft state. Differential Revision: https://secure.phabricator.com/D21286
-
epriestley authored
-
epriestley authored
Summary: Ref T13541. The passthru future does not have time limit behavior, so if we reach this code we currently fail. Phabricator never reaches this code normally, but this code is reachable during debugging if you try to foreground a slow fetch to inspect it. Passthru commands generally only make sense to run interactively, and the caller or control script can enforce their own timeouts (usually by pressing "^C" with their fingers). Test Plan: Used a debugging script to run ref-by-ref fetches in the foreground. Maniphest Tasks: T13541 Differential Revision: https://secure.phabricator.com/D21284
-
epriestley authored
Summary: See PHI1752. - Early exit of document layout can cause us to fail to populate available rows. - Some Jupyter documents have "markdown" cells with plain strings, apparently. Test Plan: Successfully rendered example diff from PHI1752. Differential Revision: https://secure.phabricator.com/D21285
-
epriestley authored
Summary: See PHI1752. - Early exit of document layout can cause us to fail to populate available rows. - Some Jupyter documents have "markdown" cells with plain strings, apparently. Test Plan: Successfully rendered example diff from PHI1752. Differential Revision: https://secure.phabricator.com/D21285
-
- 21 May, 2020 2 commits
-
-
epriestley authored
Summary: Ref T13513. When a revision has inlines with edit suggestions, pressing "j" and "k" can incorrectly select the blocks inside the diffs inside the inlines. Test Plan: Used "j" to cycle through changes in a revision with inline comments with edit suggestions, didn't get jumped into the suggestion diffs. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21283
-
epriestley authored
Summary: Ref PHI1749. Instead of opening files to the last unchanged line on either side of the change, open files to the "simple" line number of the selected block. For inlines, this is the inline line number. For blocks, this is the first new-file line number, or the first old-file line number if no new-file line number exists in the block. This may not always be what the user is hoping for (we can't know what the state of their working copy is) but should produce more obvious behavior. Test Plan: - In Diffusion, used "Open in Editor" with and without line selections. Saw same behavior as before. - Used "n" and "r" to leave an inline with the keyboard, saw same behavior as before. - Used "\" and "Open in Editor" menu item to open a file with: - Nothing selected or changeset selected (line: 1). - An inline selected (line: inline line). - A block selected (line: first line in block, per above). Differential Revision: https://secure.phabricator.com/D21282
-
- 20 May, 2020 9 commits
-
-
epriestley authored
Summary: Ref T13276. Ref T13513. All readers and writers were removed more than a year ago; clean up the last remnants of this table. Test Plan: Grepped for table references, found none. Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13513, T13276 Differential Revision: https://secure.phabricator.com/D21281
-
epriestley authored
Summary: Ref T13513. Syntax highlighting is potentially expensive, and the changeset rendering pipeline can cache it. However, the cache is currently keyed ONLY by Differential changeset ID. Destroy the existing cache and rebuild it with a more standard cache key so it can be used in a more ad-hoc way by inline suggestion snippets. Test Plan: Used Darkconsole, saw cache hits and no more inline syntax highlighting for changesets with many inlines. Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21280
-
epriestley authored
Summary: Ref T13513. Inline comment context information is somewhat expensive to construct and can be cached. Add a readthrough cache on top of it. Test Plan: Loaded a source code changeset with many inline comments, used Darkconsole to inspect query activity. Saw caches get populated. Updated cache key, saw caches regenerate. Browsed Diffusion, nothing looked broken. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21279
-
epriestley authored
Summary: Ref T13513. For now, I'm not supporting inline edit suggestions in Diffusion, although it's likely not difficult to do so in the future. Clean up some of the code so that plain ol' inlines work the same way they did before. Test Plan: - Created, edited, reloaded, submitted inlines in Diffusion: familiar old behavior. - Created, edited, reloaded, submitted inlines with suggestions in Differential: familiar new behavior. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21278
-
epriestley authored
Summary: Ref T13513. When rendering an inline suggestion for display, use highlighting and diffing. Test Plan: {F7495053} Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21277
-
epriestley authored
Summary: Ref T13513. This still has quite a few rough edges and some significant performance isssues, but appears to mostly work. Allow reviewers to "Suggest Edit" on an inline comment and provide replacement text for the highlighted source. Test Plan: Created, edited, reloaded, and submitted inline comments in various states with and without suggestion text. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21276
-
epriestley authored
Summary: Ref T13513. Introduce a formal server-side content state object so the whole state can be saved and restored to the drafts table, read from the request, etc. Test Plan: Created and edited inlines. Reloaded drafts with edits. Submitted normal and editing comments. Grepped for affected symbols. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21275
-
epriestley authored
Summary: Ref T13513. If your 10 most recently authored inlines have all been deleted, these queries can fail by overheating. This is silly and probably rarely happens outside of development. For now, just let them overheat. This may create a false negative (incorrect "no draft" signal when the real condition is "drafts, but 10 most recent comments were deleted"). This could be sorted out later with a query mode like "executeAny()", perhaps. Test Plan: - Created and deleted 10 inlines. - Submitted comments. - Before: overheating fatal during draft flag generation. - After: clean submission. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21274
-
epriestley authored
Summary: Ref T13513. Currently, all the inline code passes around strings to describe content. I plan to add background music, animation effects, etc., soon. To prepare for this change, make content a state object. This does not change any user-visible behavior, it just prepares for content to become more complicated than a single string. Test Plan: Created, edited, submitted, cancelled, etc., comments. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21273
-
- 19 May, 2020 13 commits
-
-
epriestley authored
Summary: See <https://discourse.phabricator-community.org/t/how-to-override-localhost-localdomain-in-email-message-id/3876/>. Currently, Phabricator generates a "Message-ID" only in a subset of cases (roughly: when the message is first-in-thread and we expect the thread may have more than one message). In cases where it does not generate a message ID, it expects the SMTP server to generate one for it. Servers will generally do this, and some ONLY do this (that is, they ignore IDs from Phabricator and replace them). Thus, several pieces of configuration control whether Phabricator attempts to generate a "Message-ID" at all. The PHPMailer code has fallback behavior which generates a "<random>@localhost.localdomain" message ID. This is never desirable and ignores Phabricator-level configuration that Message IDs should not be generated. For now, remove this code: it is never the desired behavior and sometimes explicitly contradicts the intent of configuration. Possibly, a better change may be to make Phabricator always generate a message ID in cases where it isn't forbidden from doing so by configuration. However, that's a more complicated change and it's not clear if/when it would produce better behavior, so start here for now. Test Plan: Confirmed by affected user (see linked thread). Differential Revision: https://secure.phabricator.com/D21272
-
epriestley authored
(stable) Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the worker queue Summary: See PHI1745. Under PHP7, errors raised as Throwable miss this "generic exception" logic and don't increment their failure count. Instead, treat any "Throwable" we don't recognize like any "Exception" we don't recognize. Test Plan: - Under PHP7, caused a worker task to raise a Throwable (e.g., call to undefined method, see D21270). - Ran `bin/worker execute --id ...`. - Before: worker failed, but did not increment failure count. - After: worker fails and increments failure count as it would for other types of unknown error. Differential Revision: https://secure.phabricator.com/D21271
-
epriestley authored
Summary: See PHI1745. Under PHP7, errors raised as Throwable miss this "generic exception" logic and don't increment their failure count. Instead, treat any "Throwable" we don't recognize like any "Exception" we don't recognize. Test Plan: - Under PHP7, caused a worker task to raise a Throwable (e.g., call to undefined method, see D21270). - Ran `bin/worker execute --id ...`. - Before: worker failed, but did not increment failure count. - After: worker fails and increments failure count as it would for other types of unknown error. Differential Revision: https://secure.phabricator.com/D21271
-
epriestley authored
Summary: See PHI1745. This callsite for "ChangesetParser" was not properly updated for recent changes. Test Plan: - Set `metamta.differential.inline-patches` to 100. - Created a new revision with a small (<100 line) diff, with at least one reviewer. - Ran `bin/phd debug` and observed outbound mail queue with `bin/mail list-outbound`. - Before: fatal when trying to generate the inline changes for mail. - After: clean mail generation. Differential Revision: https://secure.phabricator.com/D21270
-
epriestley authored
Summary: See PHI1745. This callsite for "ChangesetParser" was not properly updated for recent changes. Test Plan: - Set `metamta.differential.inline-patches` to 100. - Created a new revision with a small (<100 line) diff, with at least one reviewer. - Ran `bin/phd debug` and observed outbound mail queue with `bin/mail list-outbound`. - Before: fatal when trying to generate the inline changes for mail. - After: clean mail generation. Differential Revision: https://secure.phabricator.com/D21270
-
epriestley authored
Summary: See PHI1743. If a build has no initiator PHID, the rendering pathway incorrectly tries to access a handle for it anyway. Test Plan: - Set a build to have no initiator PHID. - Viewed the build plan for the build. - Before: fatal when trying to access the `null` handle. - After: clean build plan rendering. Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Differential Revision: https://secure.phabricator.com/D21269
-
epriestley authored
Summary: See PHI1743. If a build has no initiator PHID, the rendering pathway incorrectly tries to access a handle for it anyway. Test Plan: - Set a build to have no initiator PHID. - Viewed the build plan for the build. - Before: fatal when trying to access the `null` handle. - After: clean build plan rendering. Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Differential Revision: https://secure.phabricator.com/D21269
-
epriestley authored
Summary: Ref T13513. The code which added "r" and "R" to the inline menu accidentally discarded the difference between the keystrokes. Test Plan: - Clicked an inline, pressed "r", got new empty inline (previously: inline with quote). - Clicked an inline, pressed "R", got a new quoted inline. - Repeated steps with the menu items, got the expected behaviors. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21268
-
epriestley authored
Summary: Ref T13513. The code which added "r" and "R" to the inline menu accidentally discarded the difference between the keystrokes. Test Plan: - Clicked an inline, pressed "r", got new empty inline (previously: inline with quote). - Clicked an inline, pressed "R", got a new quoted inline. - Repeated steps with the menu items, got the expected behaviors. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21268
-
epriestley authored
(stable) Fix an unusual issue with intradiff highlighting of files with uncommon end-of-file modifications Summary: Fixes T13539. See that task for discussion and a reproduction case. This algorithm currently counts "\ No newline at end of file" lines as though they were normal source lines. This can cause offset issues in the rare case that a diff contains two of these lines (for each side of the file) and has changes between them (because the last line of the file was modified between the diffs). Instead, don't count "\" as a display line. Test Plan: - See T13539 and PHI1740. - Before: got fatals on the "wild" diff and the synthetic simplified version. - After: clean intradiff rendering in both cases. Maniphest Tasks: T13539 Differential Revision: https://secure.phabricator.com/D21267
-
epriestley authored
Summary: Fixes T13539. See that task for discussion and a reproduction case. This algorithm currently counts "\ No newline at end of file" lines as though they were normal source lines. This can cause offset issues in the rare case that a diff contains two of these lines (for each side of the file) and has changes between them (because the last line of the file was modified between the diffs). Instead, don't count "\" as a display line. Test Plan: - See T13539 and PHI1740. - Before: got fatals on the "wild" diff and the synthetic simplified version. - After: clean intradiff rendering in both cases. Maniphest Tasks: T13539 Differential Revision: https://secure.phabricator.com/D21267
-
epriestley authored
Summary: Ref T13538. See PHI1739. Synthetic Git commits with no author and/or no commit message currently extract `null` and then fail to parse. Ideally, we would carefully distinguish between `null` and empty string. In practice, that requires significant schema changes (these columns are non-nullable and have indexing requirements) and these cases are degenerate. These commits are challenging to build and can not normally be constructed with `git commit`. At least for now, merge the `null` cases into the empty string cases so we can survive import. Test Plan: - Constructed a commit with no author and no commit message using the approach described in T13538; pushed and parsed it. - Before: fatals during identity selection and storing the commit message (both roughly NULL inserts into non-null columns). - After: clean import. This produces a less-than-ideal UI in Diffusion, but it doesn't break anything: {F7492094} Maniphest Tasks: T13538 Differential Revision: https://secure.phabricator.com/D21266
-
epriestley authored
Summary: Ref T13538. See PHI1739. Synthetic Git commits with no author and/or no commit message currently extract `null` and then fail to parse. Ideally, we would carefully distinguish between `null` and empty string. In practice, that requires significant schema changes (these columns are non-nullable and have indexing requirements) and these cases are degenerate. These commits are challenging to build and can not normally be constructed with `git commit`. At least for now, merge the `null` cases into the empty string cases so we can survive import. Test Plan: - Constructed a commit with no author and no commit message using the approach described in T13538; pushed and parsed it. - Before: fatals during identity selection and storing the commit message (both roughly NULL inserts into non-null columns). - After: clean import. This produces a less-than-ideal UI in Diffusion, but it doesn't break anything: {F7492094} Maniphest Tasks: T13538 Differential Revision: https://secure.phabricator.com/D21266
-
- 18 May, 2020 2 commits
-
-
epriestley authored
Summary: Fixes T13536. See that task for discussion. Older versions of MySQL (roughly, prior to 8.0.19) emit "int(10)" types. Newer versions emit "int" types. Accept these as equivalent. Test Plan: Ran `bin/storage upgrade --force` against MySQL 8.0.11 and 8.0.20. Got clean adjustment lists on both versions. Maniphest Tasks: T13536 Differential Revision: https://secure.phabricator.com/D21265
-
epriestley authored
Summary: On the "New User" web workflow, if you use an invalid email address, you get a failure with an empty message. Test Plan: - Before: Tried to create a new user with address "asdf". Got no specific guidance. - After: Got specific guidance about email address formatting and length. Differential Revision: https://secure.phabricator.com/D21264
-
- 15 May, 2020 3 commits
-
-
epriestley authored
Summary: Ref T13513. On `secure`, I caught an issue where inlines may be accessed directly before they're constructed. Instead, access them through the relevant accessor. Test Plan: Will deploy. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21263
-
epriestley authored
Summary: Ref T13513. On `secure`, I caught an issue where inlines may be accessed directly before they're constructed. Instead, access them through the relevant accessor. Test Plan: Will deploy. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21263
-
epriestley authored
-