1. 22 Jun, 2020 4 commits
    • Ana Rute Mendes's avatar
      CCU: display RAG indicator and progress bar in task card · edf4171f
      Ana Rute Mendes authored
      Based on the custom field `std:maniphest:collabora:rag-status`
      display the RAG indicator in the task card as well as a progress
      bar that exposes the task children points.
      edf4171f
    • Daniel Stone's avatar
      LOCAL/UI: Project: Show task status in workboard cards · 4dcef812
      Daniel Stone authored
      Show the status of every task in workboard cards using the icons
      explicitly, rather than just differentiating between closed and
      not-closed.
      
      This is a local UI choice.
      4dcef812
    • Daniel Stone's avatar
      LOCAL/UI: Project: Show review/CI status on workboard · ecb1b12d
      Daniel Stone authored
      On project workboard cards, also show the status of linked code reviews;
      both the review itself, and any attached Harbormaster CI buildables.
      
      This is already taken care of in the task-detail view by 45c740ac,
      and extends it to the workboard view. It should probably share more code
      with the task-detail view.
      
      It will not be accepted upstream in its current form; it was felt in
      https://secure.phabricator.com/T7076 discussion that performing multiple
      queries for each revision to get the current state was too much. This
      makes it exceedingly unlikely that doing the same number of queries for
      every task in a workboard would be acceptable.
      
      There was discussion of how to fix that, but it was essentially
      impossible, and explicitly discouraged for anyone to even try.
      ecb1b12d
    • Daniel Stone's avatar
      WIP: Maniphest: Hide hidden project tags for tasks · b5e9b67f
      Daniel Stone authored
      If the viewer doesn't have permission to see something a task has been
      tagged with, then don't show it to them in the Maniphest task list view,
      the task detail view, or the workboard view.
      
      This should be extended further to also eliminate it from the
      transaction history (in the task detail view) and also from
      notifications, but it's a start.
      
      This would need quite a bit more work to go upstream.
      b5e9b67f
  2. 26 Mar, 2019 1 commit
    • epriestley's avatar
      Fix task hovercards showing a "Not Editable" state · 4485482f
      epriestley authored
      Summary:
      Ref T13269. These cards really have three states:
      
        - Editable: shows a pencil icon edit button.
        - You Do Not Have Permission To Edit This: shows a "no editing" icon in red.
        - Hovecard: shouldn't show anything.
      
      However, the "hovercard" and "no permission" states are currently the same state, so when I made the "no permission" state more obvious that made the hovercard go all weird.
      
      Make these states explicitly separate states.
      
      Test Plan:
      Looked at a...
      
        - Editable card on workboard: edit state.
        - No permission card on workboard: no permission state.
        - Any hovercard: "not editable, this is a hovercard" state.
      
      Reviewers: amckinley
      
      Reviewed By: amckinley
      
      Maniphest Tasks: T13269
      
      Differential Revision: https://secure.phabricator.com/D20330
      4485482f
  3. 12 Mar, 2019 1 commit
    • epriestley's avatar
      Provide better UI feedback about cards that can't be dragged or edited · 804be81f
      epriestley authored
      Summary:
      Depends on D20273. Fixes T10722. Currently, we don't make it very clear when a card can't be edited. Long ago, some code made a weak attempt to do this (by hiding the "grip" on the card), but later UI changes hid the "grip" unconditionally so that mooted things.
      
      Instead:
      
        - Replace the edit pencil with a red lock.
        - Provide cursor hints for grabbable / not grabbable.
        - Don't let users pick up cards they can't edit.
      
      Test Plan: On a workboard with a mixture of editable and not-editable cards, hovered over the different cards and was able to figure out which ones I could drag or not drag pretty easily. Picked up cards I could pick up, wasn't able to drag cards I can't edit.
      
      Reviewers: amckinley
      
      Reviewed By: amckinley
      
      Maniphest Tasks: T10722
      
      Differential Revision: https://secure.phabricator.com/D20274
      804be81f
  4. 27 Nov, 2017 1 commit
    • epriestley's avatar
      Hide archived projects only on workboards, not hovercards · 00baa3c1
      epriestley authored
      Summary:
      See PHI225. Previously, see D15335 / T10413. On workboards, we hide archived project tags since they aren't terribly useful in that context, at least most of the time. Originally, see T10349#159916 and D15297.
      
      However, hovercards reuse this display logic, and it's inconsistent/confusing to hide them there, since the actual "Tags" elements on task pages show them. Narrow the scope of this rule.
      
      Test Plan:
        - Viewed a hovercard for a task with an archived project tagged, saw archived project.
        - Viewed a workboard for the same task, saw only unarchived projects other than the current board tagged (this behavior is unchanged).
      
      Reviewers: amckinley
      
      Reviewed By: amckinley
      
      Differential Revision: https://secure.phabricator.com/D18783
      00baa3c1
  5. 26 May, 2017 1 commit
    • epriestley's avatar
      Provide UI hints about task subtypes · 742c3a83
      epriestley authored
      Summary:
      Ref T12314. Open to counterdiffs / iterating / suggestions / skipping most or all of this, mostly just throwing this out there as a maybe-reasonable first pass.
      
      When a task has a subtype (like "Plant" or "Animal"), provide some hints on the task list, workboards, and task detail.
      
      To make these hints more useful, allow subtypes to have icons and colors.
      
      Also use these icons and colors in the typeahead tokens.
      
      The current rule is that we show the subtype if it's not the default subtype. Another rule we could use is "show the subtype if there's more than one subtype defined", but my guess is that most installs will mostly have something like "normal task" as the default subtype.
      
      Test Plan:
      The interfaces this affects are: task detail view, task list view, workboard cards, subtype typeahead.
      
      {F3539128}
      
      {F3539144}
      
      {F3539167}
      
      {F3539185}
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Subscribers: johnny-bit, bbrdaric, benwick, fooishbar
      
      Maniphest Tasks: T12314
      
      Differential Revision: https://secure.phabricator.com/D17451
      742c3a83
  6. 22 May, 2017 1 commit
  7. 03 Aug, 2016 1 commit
  8. 20 May, 2016 1 commit
    • Chad Little's avatar
      Clean up "points" display on workboards · 969d3be0
      Chad Little authored
      Summary: Couple of edge cases here I never cleaned up. This inlines points and projects better, with spacing and use of grey to better differentate from project tag colors.
      
      Test Plan:
      Review edge cases on workboard with multiple short and long project names.
      
      {F1653998}
      
      {F1653999}
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin
      
      Differential Revision: https://secure.phabricator.com/D15956
      969d3be0
  9. 23 Feb, 2016 1 commit
  10. 12 Feb, 2016 1 commit
  11. 11 Feb, 2016 1 commit
  12. 10 Feb, 2016 1 commit
    • epriestley's avatar
      Rewrite workboards to have way more bugs · 0bf35190
      epriestley authored
      Summary:
      Ref T4900. Briefly:
      
        - Much more layout and rendering is now done in Javascript.
        - This should otherwise be identical to the behavior at HEAD, except that:
          - editing a task and removing the current board from it no longer removes the task; and
          - points still don't work.
      
      However, this can now plausibly support realtime workboard updates and other complex state-based behaviors like points calculations in a future change.
      
      Test Plan:
        - Changed card covers.
        - Moved cards.
        - Sorted board by priority and natural.
        - Added new cards.
        - Edited cards in place.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T4900
      
      Differential Revision: https://secure.phabricator.com/D15234
      0bf35190
  13. 06 Feb, 2016 1 commit
  14. 05 Feb, 2016 1 commit
  15. 04 Feb, 2016 1 commit
  16. 02 Feb, 2016 1 commit
    • Chad Little's avatar
      Add ownerheads to workboard cards · 7dfe0444
      Chad Little authored
      Summary: Reworks cards to add an assignee head and tooltip on workboards. This feels like a reasonable starting point, but they may move depending on feedback.
      
      Test Plan:
      View a lot of boards. Assign and unassign a task.
      
      {F1085739}
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Luke081515.2, Korvin
      
      Differential Revision: https://secure.phabricator.com/D15158
      7dfe0444
  17. 31 Jan, 2016 2 commits
    • epriestley's avatar
      Disambiguate isEmpty() · 354858e4
      epriestley authored
      Summary:
      Fixes T10250.
      
      Rename the one I added to `hasAnyProperties()` for clarity.
      
      Test Plan:
        - Viewed a project profile with content.
        - Viewed a project profile with no properties.
        - Viewed a workboard with tasks that had a mixture of additional projects and no additional projects.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T10250
      
      Differential Revision: https://secure.phabricator.com/D15151
      354858e4
    • Chad Little's avatar
      Add project tags to workboard cards · 080d838c
      Chad Little authored
      Summary: Ref T4863. Add project tags to workboard cards.
      
      Test Plan: {F1053509}
      
      Reviewers: joshuaspence, #blessed_reviewers, epriestley
      
      Reviewed By: #blessed_reviewers, epriestley
      
      Subscribers: Luke081515.2, Korvin
      
      Maniphest Tasks: T4863
      
      Differential Revision: https://secure.phabricator.com/D14935
      080d838c
  18. 09 Dec, 2015 2 commits
  19. 15 Jun, 2015 1 commit
    • Joshua Spence's avatar
      Extend from Phobject · b6d745b6
      Joshua Spence authored
      Summary: All classes should extend from some other class. See D13275 for some explanation.
      
      Test Plan: `arc unit`
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: epriestley, Korvin
      
      Differential Revision: https://secure.phabricator.com/D13283
      b6d745b6
  20. 10 Jun, 2015 1 commit
    • epriestley's avatar
      Support Spaces in Maniphest · d118800d
      epriestley authored
      Summary:
      Ref T8493. Tricks:
      
        - "Create Similar Task" and "Create Subtask" should copy the parent's Space.
        - Normal list view + workboard card view.
      
      Test Plan:
        - Created a task, edited space, etc.
        - Viewed tasks with different users.
        - Created a "Similar Task" (saw proper Space).
        - Created a subtask (saw proper Space).
        - Viewed workboard.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T8493
      
      Differential Revision: https://secure.phabricator.com/D13232
      d118800d
  21. 15 Aug, 2014 1 commit
  22. 20 May, 2014 1 commit
    • epriestley's avatar
      Allow workboards to be filtered with ApplicationSearch · f0147fd8
      epriestley authored
      Summary:
      Ref T4673.
      
      IMPORTANT: I had to break one thing (see TODO) to get this working. Not sure how you want to deal with that. I might be able to put the element //inside// the workboard, or I could write some JS. But I figured I'd get feedback first.
      
      General areas for improvement:
      
        - It would be nice to give you some feedback that you have a filter applied.
        - It would be nice to let you save and quickly select common filters.
        - These would probably both be covered by a dropdown menu instead of a button, but that's more JS than I want to sign up for right now.
        - Managing custom filters is also a significant amount of extra UI to build.
        - Also, maybe these filters should be sticky per-board? Or across all boards? Or have a "make this my default view"? I tend to dislike implicit stickiness.
      
      Test Plan:
      Before:
      
      {F157543}
      
      Apply Filter:
      
      {F157544}
      
      Filtered:
      
      {F157545}
      
      Reviewers: chad, btrahan
      
      Reviewed By: btrahan
      
      Subscribers: qgil, swisspol, epriestley
      
      Maniphest Tasks: T4673
      
      Differential Revision: https://secure.phabricator.com/D9211
      f0147fd8
  23. 12 May, 2014 1 commit
    • Chad Little's avatar
      Replace Sprite-Icons with FontAwesome · b2f3001e
      Chad Little authored
      Summary: The removes the sprite sheet 'icons' and replaces it with FontAwesome fonts.
      
      Test Plan:
      - Grep for SPRITE_ICONS and replace
      - Grep for sprite-icons and replace
      - Grep for PhabricatorActionList and choose all new icons
      - Grep for Crumbs and fix icons
      - Test/Replace PHUIList Icon support
      - Test/Replace ObjectList Icon support (foot, epoch, etc)
      - Browse as many pages as I could get to
      - Remove sprite-icons and move remarkup to own sheet
      - Review this diff in Differential
      
      Reviewers: btrahan, epriestley
      
      Reviewed By: epriestley
      
      Subscribers: epriestley, Korvin, hach-que
      
      Differential Revision: https://secure.phabricator.com/D9052
      b2f3001e
  24. 04 Mar, 2014 1 commit