phabricator merge requestshttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests2018-08-06T14:01:56Zhttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/1Restrict All users policy for top-level docs2018-08-06T14:01:56ZAna Rute MendesRestrict All users policy for top-level docsRestrict the creation of a new top-level document if visibility or
edition policies are set to "All users".
See T4759Restrict the creation of a new top-level document if visibility or
edition policies are set to "All users".
See T4759Daniel Stonedaniels@collabora.comDaniel Stonedaniels@collabora.comhttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/2LOCAL/POLICY: set sysadmin requests policies2018-10-10T20:11:20ZAna Rute MendesLOCAL/POLICY: set sysadmin requests policiesSet sysadmin requests policies according to the confidentiality
chosen by the user.Set sysadmin requests policies according to the confidentiality
chosen by the user.Daniel Stonedaniels@collabora.comDaniel Stonedaniels@collabora.comhttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/3T10714 - Trigger asset item creation in Snipe-IT when Purchase Request change...2019-08-22T12:41:26ZAna Rute MendesT10714 - Trigger asset item creation in Snipe-IT when Purchase Request changes status to "To Release"When a Purchasing Request changes status to "To Release" an asset
must be created in the inventory system, external from Phabricator.
Trigger the create asset method that is placed in the extensions folder.When a Purchasing Request changes status to "To Release" an asset
must be created in the inventory system, external from Phabricator.
Trigger the create asset method that is placed in the extensions folder.https://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/4Add snipe-it custom JavaScript validation2019-09-27T15:04:01ZAna Rute MendesAdd snipe-it custom JavaScript validationThe only way I found to add a custom js file was directly in the
webroot folder. To make sure it never generate conflicts when updating
phab, I created an extensions folder in the js directory.
This file is called by the SnipeItHelper c...The only way I found to add a custom js file was directly in the
webroot folder. To make sure it never generate conflicts when updating
phab, I created an extensions folder in the js directory.
This file is called by the SnipeItHelper class.Daniel Stonedaniels@collabora.comDaniel Stonedaniels@collabora.comhttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/5LOCAL:Maniphest: Apply approver rule to event type2019-10-29T14:58:27ZAna Rute MendesLOCAL:Maniphest: Apply approver rule to event typeReplicate the logic to auto-fill approver for `event` subtype.
Until now event and purchasing forms used the same template but
they were split in two - `purchasing` and `event` - after the
Snipe-IT integration that applied major changes...Replicate the logic to auto-fill approver for `event` subtype.
Until now event and purchasing forms used the same template but
they were split in two - `purchasing` and `event` - after the
Snipe-IT integration that applied major changes in the purchasing
request form.https://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/6CCU: purchasing: Support for multiple items2019-12-06T14:08:19ZAna Rute MendesCCU: purchasing: Support for multiple itemsAllows a ticket to have up to 5 items in the same
purchasing request.
Handle the hiding/displaying of a mini form for each asset and
control display of properties that are used only in Snipe-IT.Allows a ticket to have up to 5 items in the same
purchasing request.
Handle the hiding/displaying of a mini form for each asset and
control display of properties that are used only in Snipe-IT.https://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/7CCU: display RAG indicator and progress bar in task card2020-05-20T18:53:45ZAna Rute MendesCCU: display RAG indicator and progress bar in task cardBased on the custom field `std:maniphest:collabora:rag-status`
display the RAG indicator in the task card as well as a progress
bar that exposes the task children points.
![image](/uploads/5f8788955cb59b750b73e64177876b08/image.png)Based on the custom field `std:maniphest:collabora:rag-status`
display the RAG indicator in the task card as well as a progress
bar that exposes the task children points.
![image](/uploads/5f8788955cb59b750b73e64177876b08/image.png)Daniel Stonedaniels@collabora.comDaniel Stonedaniels@collabora.comhttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/8CCU: Ignore restricted child tasks for progress bar2020-05-21T12:43:08ZDaniel Stonedaniels@collabora.comCCU: Ignore restricted child tasks for progress barIf we have a child task which we can't access, ManiphestTaskQuery will
raise an exception; trying to view the workboard, this will bubble up as
a policy exception which will (incorrectly) tell the viewer they can't
access the project.
C...If we have a child task which we can't access, ManiphestTaskQuery will
raise an exception; trying to view the workboard, this will bubble up as
a policy exception which will (incorrectly) tell the viewer they can't
access the project.
Catch any exceptions whilst trying to calculate overall progress, and
ignore those restricted child tasks.Ana Rute MendesAna Rute Mendeshttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/9CCU: create progress bar only if task has children2020-05-21T13:16:57ZAna Rute MendesCCU: create progress bar only if task has childrenIf the task has no children it doesn't make much sense
to display the progress bar as the progress can only be 0 or 100%If the task has no children it doesn't make much sense
to display the progress bar as the progress can only be 0 or 100%Daniel Stonedaniels@collabora.comDaniel Stonedaniels@collabora.comhttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/10CCU: snipe-it: add asset tag field2020-06-02T20:13:02ZAna Rute MendesCCU: snipe-it: add asset tag fieldevery item has an asset tag that can now be manually edited from phab
cc @daniels @ajcerejeiraevery item has an asset tag that can now be manually edited from phab
cc @daniels @ajcerejeirahttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/11CCU: change progress bar color2020-06-03T23:33:44ZAna Rute MendesCCU: change progress bar colorin progress points were hard to spotin progress points were hard to spothttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/12CCU: handle snipe-IT exceptions and ticket transactions2020-06-09T20:51:06ZAna Rute MendesCCU: handle snipe-IT exceptions and ticket transactionsAfter creating items in Snipe-It we need to save in the ticket
(maniphest task) the created ids and tags. So instead of receiving only
the ids list, the SnipeIt extension will return transactions or
validation errors.
If it returns...After creating items in Snipe-It we need to save in the ticket
(maniphest task) the created ids and tags. So instead of receiving only
the ids list, the SnipeIt extension will return transactions or
validation errors.
If it returns an errror, append it to the list. If not, it's
an array of transactions so add them to the results array to update the
purchasing request.Daniel Stonedaniels@collabora.comDaniel Stonedaniels@collabora.comhttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/13Avoid multiple calls to snipe-it2020-07-24T14:21:34ZAna Rute MendesAvoid multiple calls to snipe-itPhabricator creates xactions as previews when someone is editing
the ticket through the comments section.
We do not want to trigger the asset creation/fetching in Snipe IT in
theses cases, otherwise we will
end up with duplicated actio...Phabricator creates xactions as previews when someone is editing
the ticket through the comments section.
We do not want to trigger the asset creation/fetching in Snipe IT in
theses cases, otherwise we will
end up with duplicated actions in snipe IT when phab user closes the
ticket through the comment section.
This is related to https://gitlab.collabora.com/phabricator/asset-item-application/-/merge_requests/5
CC @kov or @danielshttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/14T22727 - add customer form and serial field2020-07-29T22:58:52ZAna Rute MendesT22727 - add customer form and serial fieldThe form for customer received equipment will have its own type called `customer` to make sure purchasing and customer forms do not affect each other.
They are very similar but the fact that they don't have the exact same fields, when e...The form for customer received equipment will have its own type called `customer` to make sure purchasing and customer forms do not affect each other.
They are very similar but the fact that they don't have the exact same fields, when editing a ticket phabricator uses only one type of form, either customer or purchasing, creating undesired side effects.
ALso improve some js validation.
cc @kovDaniel Stonedaniels@collabora.comDaniel Stonedaniels@collabora.comhttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/15Synchronize test branch with latest production changes2021-03-24T18:21:16ZJames AddisonSynchronize test branch with latest production changesBrings the `deploy/test` branch back in-line with the latest `deploy/production` commits.Brings the `deploy/test` branch back in-line with the latest `deploy/production` commits.https://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/16T27069: Maniphest: Use Collabora colour branding for top navigation bar2021-03-30T13:25:37ZJames AddisonT27069: Maniphest: Use Collabora colour branding for top navigation barThis change is intended to visually distinguish Collabora's Phabricator Maniphest web interface, reducing the risk that staff confuse it with any other instances they use that are configured with the default theme.
The change is applied...This change is intended to visually distinguish Collabora's Phabricator Maniphest web interface, reducing the risk that staff confuse it with any other instances they use that are configured with the default theme.
The change is applied to the `indigo` theme.https://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/17[sync-to-production] Maniphest: Use Collabora colour branding for top navigat...2021-03-30T13:34:41ZJames Addison[sync-to-production] Maniphest: Use Collabora colour branding for top navigation barThis change is intended to visually distinguish Collabora's Phabricator Maniphest web interface, reducing the risk that staff confuse it with any other instances they use that are configured with the default theme
The change is applied ...This change is intended to visually distinguish Collabora's Phabricator Maniphest web interface, reducing the risk that staff confuse it with any other instances they use that are configured with the default theme
The change is applied to the `indigo` theme.
Maniphest Tasks: T27069https://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/18Fixup: replace commas in (stringified) Snipe-IT asset purchase_cost values2022-01-13T11:31:31ZJames AddisonFixup: replace commas in (stringified) Snipe-IT asset purchase_cost valuesResolves [T32533](https://phabricator.collabora.com/T32533).
Tested using the [shipping request form on our test instance](https://test-phabricator.collabora.com/maniphest/task/edit/form/7/).Resolves [T32533](https://phabricator.collabora.com/T32533).
Tested using the [shipping request form on our test instance](https://test-phabricator.collabora.com/maniphest/task/edit/form/7/).https://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/19tweak: remove hungry catch in snipe integration2022-07-18T09:53:12ZMark Kennedytweak: remove hungry catch in snipe integrationWe have a very hungry exception handler that masks some classes of failure in the Snipe-IT integration.
I'm proposing we remove it for now. Errors present as popups thus:
![image](/uploads/febcc2c141e1dbebf4e9c7299cd880bb/image.png)
W...We have a very hungry exception handler that masks some classes of failure in the Snipe-IT integration.
I'm proposing we remove it for now. Errors present as popups thus:
![image](/uploads/febcc2c141e1dbebf4e9c7299cd880bb/image.png)
While it is not ideal to present backtraces to "normal" (sorry) users, they can at least screenshot them and tell ~tools.
See: https://phabricator.collabora.com/T33702 and related merge request for Snipe-IT plugin https://gitlab.collabora.com/phabricator/asset-item-application/-/merge_requests/12Mark KennedyMark Kennedyhttps://gitlab.collabora.com/phabricator/phabricator/-/merge_requests/20UI: Update purple for new branding2022-04-21T09:44:01ZDaniel Stonedaniels@collabora.comUI: Update purple for new branding