Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P phabricator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • Phabricator
  • phabricator
  • Merge requests
  • !19

tweak: remove hungry catch in snipe integration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Mark Kennedy requested to merge mark/T33693-retain-snipe-errors into deploy/production Feb 25, 2022
  • Overview 1
  • Commits 1
  • Changes 1

We have a very hungry exception handler that masks some classes of failure in the Snipe-IT integration.

I'm proposing we remove it for now. Errors present as popups thus:

image

While it is not ideal to present backtraces to "normal" (sorry) users, they can at least screenshot them and tell ~tools.

See: https://phabricator.collabora.com/T33702 and related merge request for Snipe-IT plugin https://gitlab.collabora.com/phabricator/asset-item-application/-/merge_requests/12

Edited Feb 25, 2022 by Mark Kennedy
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mark/T33693-retain-snipe-errors