This can be used by actions that need the lava scripts available but not
on the DUT, i.e. they want a local overlay, but not one installed to the
device, so they don't return True for needs_overlay().

The later was already a copy.

Signed-off-by: Rémi Duraffort <remi.duraffort@linaro.org>

In 230fad50

 we added support for adding test shell variables in the
device dictionary. This patch adds support for overriding these
variables in the job definition or define additional variables there.

Signed-off-by: Tim Jaacks <tim.jaacks@garz-fricke.com>

Signed-off-by: Rémi Duraffort <remi.duraffort@linaro.org>

- Add device['dynamic_data'] to share across namespaces
- actions/deploy/{apply_,}overlay.py: Set NFS server ip and folder
- lava_dispatcher/actions/boot/environment.py: Export NFS information.

Change-Id: If3c7be49b0d2ace39697ac96b59c6771ff406d7d
Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>

In the overlay "envrionment" file the test writter can now have access to
device_info, static_info and storage_info.

Idea-from: Aníbal Limón <anibal.limon@linaro.org>
Signed-off-by: Rémi Duraffort <remi.duraffort@linaro.org>

This patch adds the field "environment" to the device dictionary,
containing device-specific shell variables which will be available in
the LAVA test shell.

These can be used, for example, to describe physical hardware
connections between the DUT and interfaces on the worker or other
addressable hardware.

Closes lava/lava#228.

Signed-off-by: Tim Jaacks <tim.jaacks@garz-fricke.com>

Also activate another class of warnings (elif).

Closes #237

Signed-off-by: Rémi Duraffort <remi.duraffort@linaro.org>

The key is never used and does change the schema that we might want to fully
validate.

Signed-off-by: Rémi Duraffort <remi.duraffort@linaro.org>
Reviewed-by: Neil Williams <neil.williams@linaro.org>
Tested-by: _Marge_Bot <https://git.lavasoftware.org/lava/lava/merge_requests/262>

Closes: #186 - black formattting had caused bandit to miss
some overrides.

Signed-off-by: Neil Williams <neil.williams@linaro.org>

Exclude action.py and parser.py which need some
formatting changes.
Change the black task to exclude the remaining files.

Signed-off-by: Neil Williams <neil.williams@linaro.org>

The action is already not adding anything in his sub-pipeline if the overlay is
not needed.

Signed-off-by: Rémi Duraffort <remi.duraffort@linaro.org>

Reduce the noise in the SAST report further.
Override bandit warnings in lava-dispatcher as bandit is
overly based on a web UI mindset.
Add overrides and fixes for files in ./share/

Signed-off-by: Neil Williams <neil.williams@linaro.org>

Update for some occurrences of W604 but exclude files
where this is unrealistic.
Ignore W504 as this currently conflicts with black.

Signed-off-by: Neil Williams <neil.williams@linaro.org>

Document that 'os' is approximate when it is used.
Document when it is still required.
Document that other uses are deprecated.
Allow the overlay to pick up common POSIX constants.

Change-Id: I1f7c8f27615cd33a8d2b505a3f0563373f8111f4

Change-Id: I9d61efc457fb5e49ac1b3ad56acaa1b453b9cc4a

This argument is not used anymore.

Change-Id: I9cc98ed14003e79110c820149570cc1248549535

When called with exist_ok=True, os.makedirs will not raise an exception when
trying to create an existing directory.

Change-Id: I70a473bbf0f2a02d9f00544ec5ebbca382047b04

Make a clear separation between lava_server and lava_dispatcher
binary packages so that a master does not need all the dependencies
of lava-dispatcher installed (and does not necessarily have a
local worker).
Update documentation on how lava-common can be used.

Change-Id: I040a44c7ce6d853524ccc33e08df593b0d14c54f

Change-Id: I8bc55876f82817533dfef42128aefea15c904311

Setting self.error will raise a JobError while an InfrastructureError is needed
here.

Change-Id: I233dcb1e28aaa6f75fa2c263fc0a9596ce33710d

This can be used to create the overlay that will then be used with
"transfer_overlay".

Change-Id: Ia755b56ee47bff0c951af93e433fcee8753d1eca

Raise LavaBug instead of showing a python traceback

Change-Id: Ifd9aad4ea4b73c267b150a43a8dabd4209dc22a6

The transfer_overlay is then using this exact location which is already served
by the http server.
This patch make the url unique and fix clashes when two lava jobs are using
transfer_overlay on the same dispatcher.

Reported-by: Wang, Yang (Young) <ywangwrs@gmail.com>

Change-Id: Ic7a1707623c2525a1b2ba709ce8bc12a7fe920ed

Change-Id: I5d39d205e92f43c087bdef3ac966723179c83110

This also fix the name when calling parent __init__ function.

Change-Id: I302c3920eed9ef51232e22d75d555f0d34abf510

key "lava_test_results_dir" should be under the "results" label. The code was
duplicated in most deploy methods to fix this first typo.

Change-Id: I3377d3f38ac81fb2eff564817399095f4228dc74

Adding probe_ip and probe_channel into static_info. This allows job
writers to connect to energy probes via the test shell using the same
method we do for device_ip and device_mac.

Change-Id: I1fa0529f00a178021fe324a2d79280747a37296f

Needs a parallel documentation change. Based on lava-group.
Uses new entry in device dictionary:
storage_info:
- 'UMS': "/dev/disk/by-id/usb-Linux_UMS_disk_0_0054-0:0"

Change-Id: I8e9783aee87ddb3bb3581ada4360c1b4679b3762

Update overlay preparation for change in path.

Change-Id: I0b45fd82a39e23579184bbcd199ab5af5417f0d0

Also sort the list of helpers to make logs a bit more predictable and readable.

Change-Id: I88beca9703f79db7d0c78fe1b38216bbe242f7fb

Change-Id: I51db97a365478850bb625185358d2ac9807ba1a0

Change-Id: I098edd9edfeb968b303eaedc6afb6654e43b4b98

Otherwise later actions might fail for some strange reasons.

Change-Id: Icbc5c3ec96817501e32d17f113447aededbb546b

They are not used and always defaulting to "device".

Change-Id: I2d266043176d811f226b5771726974cd8f88f705

Make it easier to follow overlay and protocol handling.
Clarify which actions are being performed in MultiNode.
Clarify which namespace is active when handling overlays.

Change-Id: I8dfce13928ac89c5ddb9747268cf24e4edc3d70f

In case of error, an exception should be raised.

Change-Id: I8425bde50067c76c84119a2018ef54c00d6e9e4f

Local and unit tests pass but once built, these files need to be
included in the overlay.
Add debug showing when distro overrides are done.

Change-Id: I7df47eff9e89ebd523ffd02035d406036e2e7cc4

All these exceptions are inheriting from LAVAException. Hence it's easy to
classify and catch them.

Change-Id: Ib99db6145efdeedbfc03755a2787158469aa6fac

Fix variables shadowing external contexts.
Fix unused imports or unused variables.
Fix missing item in docstring.

Change-Id: I5ffb8e0208cd7e354131ac31355b5e736f8195be