Skip to content
  • Arnd Bergmann's avatar
    irqchip/mvebu-odmi: Select GENERIC_MSI_IRQ_DOMAIN · fa23b9d1
    Arnd Bergmann authored
    
    
    This driver uses the MSI domain but has no strict dependency on PCI_MSI, so we
    may run into a build failure when CONFIG_GENERIC_MSI_IRQ_DOMAIN is disabled:
    
    drivers/irqchip/irq-mvebu-odmi.c:152:15: error: variable 'odmi_msi_ops' has initializer but incomplete type
     static struct msi_domain_ops odmi_msi_ops = {
                   ^~~~~~~~~~~~~~
    drivers/irqchip/irq-mvebu-odmi.c:155:15: error: variable 'odmi_msi_domain_info' has initializer but incomplete type
     static struct msi_domain_info odmi_msi_domain_info = {
                   ^~~~~~~~~~~~~~~
    drivers/irqchip/irq-mvebu-odmi.c:156:3: error: 'struct msi_domain_info' has no member named 'flags'
      .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
       ^~~~~
    drivers/irqchip/irq-mvebu-odmi.c:156:12: error: 'MSI_FLAG_USE_DEF_DOM_OPS' undeclared here (not in a function)
      .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
                ^~~~~~~~~~~~~~~~~~~~~~~~
    drivers/irqchip/irq-mvebu-odmi.c:156:39: error: 'MSI_FLAG_USE_DEF_CHIP_OPS' undeclared here (not in a function); did you mean 'MSI_FLAG_USE_DEF_DOM_OPS'?
    
    Selecting the option from this driver seems to solve this nicely, though I could
    not find any other instance of this in irqchip drivers.
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarThomas Petazzoni <thomas.petazzoni@free-electrons.com>
    Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
    fa23b9d1