Skip to content
  • James Hogan's avatar
    MIPS: Fix undefined reference to physical_memsize · f35764e7
    James Hogan authored
    Since commit d41e6858 ("MIPS: Kconfig: Set default MIPS system type
    as generic") switched the default platform to the "generic" platform,
    allmodconfig has been failing with the following linker error (among
    other errors):
    
    arch/mips/kernel/vpe-mt.o In function `vpe_run':
    (.text+0x59c): undefined reference to `physical_memsize'
    
    The Lantiq platform already worked around the same issue in commit
    9050d50e ("MIPS: lantiq: Set physical_memsize") by declaring
    physical_memsize with the initial value of 0 (on the assumption that the
    actual memory size will be hard-coded in the loaded VPE firmware), and
    the Malta platform already provided physical_memsize.
    
    Since all other platforms will fail to link with the VPE loader enabled,
    only allow Lantiq and Malta platforms to enable it, by way of a
    SYS_SUPPORTS_VPE_LOADER which is selected by those two platforms and
    which MIPS_VPE_LOADER depends on. SYS_SUPPORTS_MULTITHREADING is now a
    dependency of SYS_SUPPORTS_VPE_LOADER so that Kconfig emits a warning if
    SYS_SUPPORTS_VPE_LOADER is selected without SYS_SUPPORTS_MULTITHREADING.
    
    Fixes: d41e6858
    
     ("MIPS: Kconfig: Set default MIPS system type as generic")
    Signed-off-by: default avatarJames Hogan <jhogan@kernel.org>
    Cc: Ralf Baechle <ralf@linux-mips.org>
    Cc: John Crispin <john@phrozen.org>
    Cc: Hauke Mehrtens <hauke@hauke-m.de>
    Cc: Paul Burton <paul.burton@mips.com>
    Cc: Matt Redfearn <matt.redfearn@imgtec.com>
    Cc: Guenter Roeck <linux@roeck-us.net>
    Cc: linux-mips@linux-mips.org
    Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Patchwork: https://patchwork.linux-mips.org/patch/18453/
    f35764e7