Commit 1d957f9b authored by Jan Blunck's avatar Jan Blunck Committed by Linus Torvalds
Browse files

Introduce path_put()



* Add path_put() functions for releasing a reference to the dentry and
  vfsmount of a struct path in the right order

* Switch from path_release(nd) to path_put(&nd->path)

* Rename dput_path() to path_put_conditional()

[akpm@linux-foundation.org: fix cifs]
Signed-off-by: default avatarJan Blunck <jblunck@suse.de>
Signed-off-by: default avatarAndreas Gruenbacher <agruen@suse.de>
Acked-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: <linux-fsdevel@vger.kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Steven French <sfrench@us.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 4ac91378
......@@ -260,7 +260,7 @@ osf_statfs(char __user *path, struct osf_statfs __user *buffer, unsigned long bu
retval = user_path_walk(path, &nd);
if (!retval) {
retval = do_osf_statfs(nd.path.dentry, buffer, bufsiz);
path_release(&nd);
path_put(&nd.path);
}
return retval;
}
......
......@@ -711,7 +711,7 @@ asmlinkage int irix_statfs(const char __user *path,
}
dput_and_out:
path_release(&nd);
path_put(&nd.path);
out:
return error;
}
......@@ -1385,7 +1385,7 @@ asmlinkage int irix_statvfs(char __user *fname, struct irix_statvfs __user *buf)
error |= __put_user(0, &buf->f_fstr[i]);
dput_and_out:
path_release(&nd);
path_put(&nd.path);
out:
return error;
}
......@@ -1636,7 +1636,7 @@ asmlinkage int irix_statvfs64(char __user *fname, struct irix_statvfs64 __user *
error |= __put_user(0, &buf->f_fstr[i]);
dput_and_out:
path_release(&nd);
path_put(&nd.path);
out:
return error;
}
......
......@@ -222,7 +222,7 @@ asmlinkage long hpux_statfs(const char __user *path,
error = vfs_statfs_hpux(nd.path.dentry, &tmp);
if (!error && copy_to_user(buf, &tmp, sizeof(tmp)))
error = -EFAULT;
path_release(&nd);
path_put(&nd.path);
}
return error;
}
......
......@@ -73,7 +73,7 @@ static long do_spu_create(const char __user *pathname, unsigned int flags,
LOOKUP_OPEN|LOOKUP_CREATE, &nd);
if (!ret) {
ret = spufs_create(&nd, flags, mode, neighbor);
path_release(&nd);
path_put(&nd.path);
}
putname(tmp);
}
......
......@@ -436,7 +436,7 @@ asmlinkage int solaris_statvfs(u32 path, u32 buf)
if (!error) {
struct inode *inode = nd.path.dentry->d_inode;
error = report_statvfs(nd.path.mnt, inode, buf);
path_release(&nd);
path_put(&nd.path);
}
return error;
}
......@@ -466,7 +466,7 @@ asmlinkage int solaris_statvfs64(u32 path, u32 buf)
if (!error) {
struct inode *inode = nd.path.dentry->d_inode;
error = report_statvfs64(nd.path.mnt, inode, buf);
path_release(&nd);
path_put(&nd.path);
}
unlock_kernel();
return error;
......
......@@ -375,7 +375,7 @@ static int lookup_device(const char *path, dev_t *dev)
*dev = inode->i_rdev;
out:
path_release(&nd);
path_put(&nd.path);
return r;
}
......
......@@ -203,7 +203,7 @@ int get_sb_mtd(struct file_system_type *fs_type, int flags,
goto not_an_MTD_device;
mtdnr = iminor(nd.path.dentry->d_inode);
path_release(&nd);
path_put(&nd.path);
return get_sb_mtd_nr(fs_type, flags, dev_name, data, mtdnr, fill_super,
mnt);
......@@ -214,7 +214,7 @@ int get_sb_mtd(struct file_system_type *fs_type, int flags,
"MTD: Attempt to mount non-MTD device \"%s\"\n",
dev_name);
out:
path_release(&nd);
path_put(&nd.path);
return ret;
}
......
......@@ -227,7 +227,7 @@ static void *afs_mntpt_follow_link(struct dentry *dentry, struct nameidata *nd)
newmnt = afs_mntpt_do_automount(nd->path.dentry);
if (IS_ERR(newmnt)) {
path_release(nd);
path_put(&nd->path);
return (void *)newmnt;
}
......
......@@ -383,7 +383,7 @@ static void *autofs4_follow_link(struct dentry *dentry, struct nameidata *nd)
return NULL;
out_error:
path_release(nd);
path_put(&nd->path);
return ERR_PTR(status);
}
......
......@@ -1409,7 +1409,7 @@ struct block_device *lookup_bdev(const char *path)
if (!bdev)
goto fail;
out:
path_release(&nd);
path_put(&nd.path);
return bdev;
fail:
bdev = ERR_PTR(error);
......
......@@ -368,7 +368,7 @@ cifs_dfs_follow_mountpoint(struct dentry *dentry, struct nameidata *nd)
cFYI(1, ("leaving %s" , __FUNCTION__));
return ERR_PTR(rc);
out_err:
path_release(nd);
path_put(&nd->path);
goto out;
}
......
......@@ -80,7 +80,7 @@ static int coda_pioctl(struct inode * inode, struct file * filp,
/* return if it is not a Coda inode */
if ( target_inode->i_sb != inode->i_sb ) {
path_release(&nd);
path_put(&nd.path);
return -EINVAL;
}
......@@ -89,7 +89,7 @@ static int coda_pioctl(struct inode * inode, struct file * filp,
error = venus_pioctl(inode->i_sb, &(cnp->c_fid), cmd, &data);
path_release(&nd);
path_put(&nd.path);
return error;
}
......@@ -244,7 +244,7 @@ asmlinkage long compat_sys_statfs(const char __user *path, struct compat_statfs
error = vfs_statfs(nd.path.dentry, &tmp);
if (!error)
error = put_compat_statfs(buf, &tmp);
path_release(&nd);
path_put(&nd.path);
}
return error;
}
......@@ -312,7 +312,7 @@ asmlinkage long compat_sys_statfs64(const char __user *path, compat_size_t sz, s
error = vfs_statfs(nd.path.dentry, &tmp);
if (!error)
error = put_compat_statfs64(buf, &tmp);
path_release(&nd);
path_put(&nd.path);
}
return error;
}
......
......@@ -103,7 +103,7 @@ static int get_target(const char *symname, struct nameidata *nd,
*target = configfs_get_config_item(nd->path.dentry);
if (!*target) {
ret = -ENOENT;
path_release(nd);
path_put(&nd->path);
}
} else
ret = -EPERM;
......@@ -141,7 +141,7 @@ int configfs_symlink(struct inode *dir, struct dentry *dentry, const char *symna
ret = create_link(parent_item, target_item, dentry);
config_item_put(target_item);
path_release(&nd);
path_put(&nd.path);
out_put:
config_item_put(parent_item);
......
......@@ -1643,7 +1643,7 @@ int vfs_quota_on(struct super_block *sb, int type, int format_id, char *path)
error = vfs_quota_on_inode(nd.path.dentry->d_inode, type,
format_id);
out_path:
path_release(&nd);
path_put(&nd.path);
return error;
}
......
......@@ -526,7 +526,7 @@ static int ecryptfs_read_super(struct super_block *sb, const char *dev_name)
rc = 0;
goto out;
out_free:
path_release(&nd);
path_put(&nd.path);
out:
return rc;
}
......
......@@ -148,7 +148,7 @@ asmlinkage long sys_uselib(const char __user * library)
return error;
exit:
release_open_intent(&nd);
path_release(&nd);
path_put(&nd.path);
goto out;
}
......@@ -672,7 +672,7 @@ struct file *open_exec(const char *name)
}
}
release_open_intent(&nd);
path_release(&nd);
path_put(&nd.path);
}
goto out;
}
......
......@@ -2759,7 +2759,7 @@ static int ext3_quota_on(struct super_block *sb, int type, int format_id,
return err;
/* Quotafile not on the same filesystem? */
if (nd.path.mnt->mnt_sb != sb) {
path_release(&nd);
path_put(&nd.path);
return -EXDEV;
}
/* Quotafile not of fs root? */
......@@ -2767,7 +2767,7 @@ static int ext3_quota_on(struct super_block *sb, int type, int format_id,
printk(KERN_WARNING
"EXT3-fs: Quota file not on filesystem root. "
"Journalled quota will not work.\n");
path_release(&nd);
path_put(&nd.path);
return vfs_quota_on(sb, type, format_id, path);
}
......
......@@ -3159,7 +3159,7 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id,
return err;
/* Quotafile not on the same filesystem? */
if (nd.path.mnt->mnt_sb != sb) {
path_release(&nd);
path_put(&nd.path);
return -EXDEV;
}
/* Quotafile not of fs root? */
......@@ -3167,7 +3167,7 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id,
printk(KERN_WARNING
"EXT4-fs: Quota file not on filesystem root. "
"Journalled quota will not work.\n");
path_release(&nd);
path_put(&nd.path);
return vfs_quota_on(sb, type, format_id, path);
}
......
......@@ -900,7 +900,7 @@ static struct super_block* get_gfs2_sb(const char *dev_name)
"mount point %s\n", dev_name);
free_nd:
path_release(&nd);
path_put(&nd.path);
out:
return sb;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment