Commit 535131e6 authored by Mel Gorman's avatar Mel Gorman Committed by Linus Torvalds
Browse files

Choose pages from the per-cpu list based on migration type

The freelists for each migrate type can slowly become polluted due to the
per-cpu list.  Consider what happens when the following happens

1. A 2^(MAX_ORDER-1) list is reserved for __GFP_MOVABLE pages
2. An order-0 page is allocated from the newly reserved block
3. The page is freed and placed on the per-cpu list
4. alloc_page() is called with GFP_KERNEL as the gfp_mask
5. The per-cpu list is used to satisfy the allocation

This results in a kernel page is in the middle of a migratable region. This
patch prevents this leak occuring by storing the MIGRATE_ type of the page in
page->private. On allocate, a page will only be returned of the desired type,
else more pages will be allocated. This may temporarily allow a per-cpu list
to go over the pcp->high limit but it'll be corrected on the next free. Care
is taken to preserve the hotness of pages recently freed.

The additional code is not measurably slower for the workloads we've tested.
Signed-off-by: default avatarMel Gorman <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent b2a0ac88
......@@ -760,7 +760,8 @@ static int rmqueue_bulk(struct zone *zone, unsigned int order,
struct page *page = __rmqueue(zone, order, migratetype);
if (unlikely(page == NULL))
list_add_tail(&page->lru, list);
list_add(&page->lru, list);
set_page_private(page, migratetype);
return i;
......@@ -887,6 +888,7 @@ static void fastcall free_hot_cold_page(struct page *page, int cold)
list_add(&page->lru, &pcp->list);
set_page_private(page, get_pageblock_migratetype(page));
if (pcp->count >= pcp->high) {
free_pages_bulk(zone, pcp->batch, &pcp->list, 0);
......@@ -951,9 +953,27 @@ static struct page *buffered_rmqueue(struct zonelist *zonelist,
if (unlikely(!pcp->count))
goto failed;
page = list_entry(pcp->, struct page, lru);
/* Find a page of the appropriate migrate type */
list_for_each_entry(page, &pcp->list, lru) {
if (page_private(page) == migratetype) {
* Check if a page of the appropriate migrate type
* was found. If not, allocate more to the pcp list
if (&page->lru == &pcp->list) {
pcp->count += rmqueue_bulk(zone, 0,
pcp->batch, &pcp->list, migratetype);
page = list_entry(pcp->, struct page, lru);
VM_BUG_ON(page_private(page) != migratetype);
} else {
spin_lock_irqsave(&zone->lock, flags);
page = __rmqueue(zone, order, migratetype);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment