Commit f1deaee0 authored by Marek Vasut's avatar Marek Vasut Committed by Marc Kleine-Budde
Browse files

can: ifi: Fix TX DLC configuration

The TX DLC, the transmission length information, was not written
into the transmit configuration register. When using the CAN core
with different CAN controller, the receiving CAN controller will
receive only the ID part of the CAN frame, but no data at all.

This patch adds the TX DLC into the register to fix this issue.
Signed-off-by: default avatarMarek Vasut <>
Cc: Marc Kleine-Budde <>
Cc: Mark Rutland <>
Cc: Oliver Hartkopp <>
Cc: Wolfgang Grandegger <>
Reviewed-by: default avatarOliver Hartkopp <>
Signed-off-by: default avatarMarc Kleine-Budde <>
parent 99312c37
......@@ -749,8 +749,7 @@ static netdev_tx_t ifi_canfd_start_xmit(struct sk_buff *skb,
struct ifi_canfd_priv *priv = netdev_priv(ndev);
struct canfd_frame *cf = (struct canfd_frame *)skb->data;
u32 txst, txid;
u32 txdlc = 0;
u32 txst, txid, txdlc;
int i;
if (can_dropped_invalid_skb(ndev, skb))
......@@ -773,12 +772,11 @@ static netdev_tx_t ifi_canfd_start_xmit(struct sk_buff *skb,
txid = cf->can_id & CAN_SFF_MASK;
if (priv->can.ctrlmode & (CAN_CTRLMODE_FD | CAN_CTRLMODE_FD_NON_ISO)) {
if (can_is_canfd_skb(skb)) {
if (cf->flags & CANFD_BRS)
txdlc = can_len2dlc(cf->len);
if ((priv->can.ctrlmode & CAN_CTRLMODE_FD) && can_is_canfd_skb(skb)) {
if (cf->flags & CANFD_BRS)
if (cf->can_id & CAN_RTR_FLAG)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment