From 320f7aa139e29069bd840f688bdea0305c2c3d5c Mon Sep 17 00:00:00 2001 From: "Wladimir J. van der Laan" <laanwj@gmail.com> Date: Sun, 23 Jul 2017 13:24:39 +0200 Subject: [PATCH] etnaviv: Clear lbl_usage array correctly Fill the entire array instead of just a quarter. This avoids crashes with large shaders. (currently this never causes a problem because shaders larger than 2048/4 instructions are not supported by this driver on any hardware, but it will cause problems in the future) Fixes: ec436051899 ("etnaviv: fix shader miscompilation with more than 16 labels") Cc: mesa-stable@lists.freedesktop.org Signed-off-by: Wladimir J. van der Laan <laanwj@gmail.com> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_compiler.c b/src/gallium/drivers/etnaviv/etnaviv_compiler.c index 2e8dd8643a5..faad520bd80 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_compiler.c +++ b/src/gallium/drivers/etnaviv/etnaviv_compiler.c @@ -2304,7 +2304,7 @@ etna_compile_shader(struct etna_shader_variant *v) if (!c) return false; - memset(&c->lbl_usage, -1, ARRAY_SIZE(c->lbl_usage)); + memset(&c->lbl_usage, -1, sizeof(c->lbl_usage)); const struct tgsi_token *tokens = v->shader->tokens; -- GitLab