~/.local/share/Steam/ubuntu12_32/steam has a symbol with a weird
binding type part way through its symbol table:

46 [OBJECT   LOOS/GNU_UNIQUE] size: 0 (0)_ZNSs4_Rep20_S_empty_rep_storageE 0000 (nil)

but we can't just stop there, because there are symbols after it that
need relocating.

I blame C++.

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

This avoids reinventing it.

Signed-off-by: Simon McVittie <smcv@collabora.com>

This seemed easier than fixing the corner cases individually.

Signed-off-by: Simon McVittie <smcv@collabora.com>

This makes it a little simpler to reason about.

Signed-off-by: Simon McVittie <smcv@collabora.com>

If PATH_MAX bytes aren't enough for anyone, smashing the stack or heap
is a poor way to report it.

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

ptr_list_push_addr - unconditionaly add an ElfW(Addr)
ptr_list_push_ptr  - unconditionaly add a void *
ptr_list_contains  - check if an ElfW(addr) is present
ptr_list_add_ptr   - add a void * only if not currently in list
ptr_list_push      - renamed to ptr_list_push_addr

Conflicts:
	utils/utils.c

Signed-off-by: Simon McVittie <smcv@collabora.com>

Use the right type for that role.

Signed-off-by: Simon McVittie <smcv@collabora.com>

base is a valid pointer into memory, whereas start is only an offset
and so is not a pointer that we can dereference. Previously, base was
a pointer-sized integer and start was a pointer, which is exactly
backwards if we want to stick to a rule of "it's a pointer iff
you could dereference it".

Signed-off-by: Simon McVittie <smcv@collabora.com>

Previously, we would have tried to adjust stab according to the base
address, so in practice we'd return base, which the observant will
note is not a string table.

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

<3 not having to support MSVC in this codebase

Signed-off-by: Simon McVittie <smcv@collabora.com>

Partially works. The capsule_relocate_except seen-it cache works.

The one for capsule_relocate needs to be off for now - for some reason
it makes Dungeon Defenders not work. Still faster than no seen-it
filter at all though.

Signed-off-by: Simon McVittie <smcv@collabora.com>

Some ElfW(Rel[a]) d_ptr items are pre-calculated form base, others not.

The removal of the addr() address/base fixup logic aldo turns out
to have been premature, so restored for the find_ptr() helper.

This could be a bug if the implicit declaration doesn't have the
same ABI that we actually implement.

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

In addition to wrapping dlopen() inside the capsule we need to
wrap dlsym() outside the capsule in order to allow libraries
that use a dlopen()/dlsym() pattern to work transparently.

capsule_shim_dlsym() bundles most of the standard logic we
expect such wrappers to use.