1. 01 May, 2013 3 commits
  2. 30 Apr, 2013 14 commits
  3. 29 Apr, 2013 2 commits
  4. 26 Apr, 2013 15 commits
    • Kay Sievers's avatar
      Makefile-man.am: update · e29380eb
      Kay Sievers authored
      e29380eb
    • Harald Hoyer's avatar
      systemd-analyse: add "critical-chain" command · bb150966
      Harald Hoyer authored
      "critical-chain" prints a tree of the critical chain of units
      
      $ ./systemd-analyze critical-chain
      graphical.target @1.226s
      └─multi-user.target @1.226s
        └─nfs-lock.service @961ms +265ms
          └─rpcbind.service @958ms +1ms
            └─network.target @957ms
              └─NetworkManager.service @434ms +522ms
                └─basic.target @428ms
                  └─sockets.target @428ms
                    └─dbus.socket @428ms
                      └─sysinit.target @427ms
                        └─systemd-tmpfiles-setup.service @411ms +15ms
                          └─local-fs.target @410ms
                            └─boot-efi.automount @410ms
                              └─boot.mount @397ms +9ms
                                └─local-fs-pre.target @192ms
                                  └─systemd-udevd.service @187ms +5ms
                                    └─systemd-udevd-control.socket @140ms
                                      └─-.mount
      
      With the "--fuzz=<ms>" parameter one can display more units around
      the critical units.
      
      $ ./systemd-analyze --fuzz=10ms critical-chain
      └─multi-user.target @1.226s
        └─nfs-lock.service @961ms +265ms
          ├─rpcbind.service @958ms +1ms
          │ └─network.target @957ms
          │   └─NetworkManager.service @434ms +522ms
          │     ├─basic.target @428ms
          │     │ ├─sockets.target @428ms
          │     │ │ ├─dbus.socket @428ms
          │     │ │ │ └─sysinit.target @427ms
          │     │ │ │   ├─systemd-tmpfiles-setup.service @411ms +15ms
          │     │ │ │   │ └─local-fs.target @410ms
          │     │ │ │   │   └─boot-efi.automount @410ms
          │     │ │ │   │     └─boot.mount @397ms +9ms
          │     │ │ │   │       └─local-fs-pre.target @192ms
          │     │ │ │   │         └─systemd-udevd.service @187ms +5ms
          │     │ │ │   │           ├─systemd-udevd-control.socket @140ms
          │     │ │ │   │           │ └─-.mount
          │     │ │ │   │           └─systemd-udevd-kernel.socket @140ms
          │     │ │ │   └─swap.target @421ms
          │     │ │ │     └─dev-disk-by\x2duuid-....swap @414ms +6ms
          │     │ │ │       └─systemd-journald.socket
          │     │ │ ├─rpcbind.socket @428ms
          │     │ │ └─cups.socket @428ms
          │     │ ├─paths.target @428ms
          │     │ │ └─cups.path @428ms
          │     │ ├─timers.target @427ms
          │     │ │ └─systemd-tmpfiles-clean.timer @427ms
          │     │ └─sysinit.target @427ms
          │     │   └─...
          │     └─dbus.socket @428ms
          │       └─...
          └─network.target @957ms
            └─...
      bb150966
    • Harald Hoyer's avatar
      17f5e457
    • Colin Walters's avatar
      coredump: use realloc() loop instead of malloc(768M) · 910003d0
      Colin Walters authored
      I typically run VMs with 1024MiB allocated; systemd is unable to write
      coredumps in this scenario at all because the default kernel
      configuration will only overcommit 50% of available RAM.
      
      Avoid this failure by using a realloc() loop.
      
      See: http://lists.freedesktop.org/archives/systemd-devel/2013-April/010709.html
      910003d0
    • Cristian Rodríguez's avatar
      build-sys: add --with-debug-shell=PATH · 45df1f2c
      Cristian Rodríguez authored
      Distributions may have selinux but not sushell or might
      need to set a custom debug shell.
      
      Defaults to /sbin/sushell if selinux is enabled, /bin/sh if not.
      
      [zj: Renamed --with-debugshelltty to --with-debug-tty, and
           added a line in output showing DEBUGSHELL and DEBUGTTY.
           I figure that debug shell is pretty useful, and I hope
           the extra line in configure status will draw attention
           to it.]
      45df1f2c
    • Mirco Tischler's avatar
      core: remove duplicate MESSAGE= from log message · fcf8c440
      Mirco Tischler authored
      This was needed with log_struct_unit() but log_notice_unit() adds it
      anyway.
      fcf8c440
    • Zbigniew Jędrzejewski-Szmek's avatar
      Use attribute(unused) in PROTECT_ERRNO · 2a371001
      Zbigniew Jędrzejewski-Szmek authored
      clang emits warnings about unused attribute _saved_errno_, which drown
      out other—potentially useful—warnings. gcc documentation is not exactly
      verbose about the effects of __attribute__((unused)) on variables, but
      let's assume that it works if the unit test passes.
      2a371001
    • Zbigniew Jędrzejewski-Szmek's avatar
    • Zbigniew Jędrzejewski-Szmek's avatar
      readahead: fix format string issue · 406e86fd
      Zbigniew Jędrzejewski-Szmek authored
      (struct stat).st is off_t, which usually is a long, or a long long.
      There's no good format string modifier for it, so use a cast.
      406e86fd
    • Zbigniew Jędrzejewski-Szmek's avatar
      Add printf attributes in exported headers · e4d2bfdd
      Zbigniew Jędrzejewski-Szmek authored
      gcc (and other compilers) sometimes generate spurious warnings, and
      thus users of public headers must be able to disable warnings.
      
      Printf format attributes can be disabled by setting
          #define _sd_printf_attr_
      before including the header file.
      
      Also, add similar logic for sentinel attribute:
          #define _sd_sentinel_attr_
      before including the header file disables the attribute.
      e4d2bfdd
    • Cristian Rodríguez's avatar
      b1e2b33c
    • Zbigniew Jędrzejewski-Szmek's avatar
      Make up for attribute malloc with alloc_size · 750ef272
      Zbigniew Jędrzejewski-Szmek authored
      It is imperative that open source code be well attributed.
      Sprinkle attribute((alloc_size)) here and there, telling gcc
      how much memory we are actually allocating.
      750ef272
    • Zbigniew Jędrzejewski-Szmek's avatar
      Remove erroneous attribute((malloc)) annotations · b231b547
      Zbigniew Jędrzejewski-Szmek authored
      According to gcc documentation, returned pointer "cannot alias any
      other pointer valid when the function returns" and "the memory has
      undefined content". This second part is (hopefully) untrue for all
      those functions.
      b231b547
    • Zbigniew Jędrzejewski-Szmek's avatar
      systemd-python: attach fields to JournalHandler, add SYSLOG_IDENTIFIER · b5edbff0
      Zbigniew Jędrzejewski-Szmek authored
      Arbitrary fields can be attached at the level of the handler,
      and they'll be sent with all messages from this handler.
      
      This facility is used to attach SYSLOG_IDENTIFIER to all messages,
      since otherwise journald attaches SYSLOG_IDENTIFIER=python or
      something similar, which is completely useless.
      b5edbff0
    • Lennart Poettering's avatar
      unit: rework stop pending logic · 31afa0a4
      Lennart Poettering authored
      When a trigger unit wants to know if a stop is queued for it, we should
      just check precisely that and do not check whether it is actually
      stopped already. This is because we use these checks usually from state
      change calls where the state variables are not updated yet.
      
      This change splits unit_pending_inactive() into two calls
      unit_inactive_or_pending() and unit_stop_pending(). The former checks
      state and pending jobs, the latter only pending jobs.
      31afa0a4
  5. 25 Apr, 2013 6 commits