1. 11 Jul, 2014 1 commit
  2. 27 Apr, 2014 1 commit
  3. 26 Apr, 2014 3 commits
  4. 05 Apr, 2013 1 commit
    • Zbigniew Jędrzejewski-Szmek's avatar
      Use initalization instead of explicit zeroing · b92bea5d
      Zbigniew Jędrzejewski-Szmek authored
      Before, we would initialize many fields twice: first
      by filling the structure with zeros, and then a second
      time with the real values. We can let the compiler do
      the job for us, avoiding one copy.
      
      A downside of this patch is that text gets slightly
      bigger. This is because all zero() calls are effectively
      inlined:
      
      $ size build/.libs/systemd
               text    data     bss     dec     hex filename
      before 897737  107300    2560 1007597   f5fed build/.libs/systemd
      after  897873  107300    2560 1007733   f6075 build/.libs/systemd
      
      … actually less than 1‰.
      
      A few asserts that the parameter is not null had to be removed. I
      don't think this changes much, because first, it is quite unlikely
      for the assert to fail, and second, an immediate SEGV is almost as
      good as an assert.
      b92bea5d
  5. 14 Nov, 2012 1 commit
    • Zbigniew Jędrzejewski-Szmek's avatar
      build-sys: store journald code in a noinst library · d025f1e4
      Zbigniew Jędrzejewski-Szmek authored
      The point is to allow the use of journald functions by other binaries.
      Before, journald code was split into multiple files (journald-*.[ch]),
      but all those files all required functions from journald.c. And
      journald.c has its own main(). Now, it is possible to link against
      those functions, e.g. from test binaries.
      
      This constitutes a fix for https://bugzilla.redhat.com/show_bug.cgi?id=872638.
      
      The patch does the following:
      1. rename journald.h to journald-server.h and move corresponding code
         to journald-server.c.
      2. add journald-server.c and other journald-*.c parts to
         libsystemd-journal-internal.
      3. remove journald-syslog.c from test_journal_syslog_SOURCES, since
         it is now contained in libsystemd-journal-internal.
      There are no code changes, apart from the removal of a few static's,
      to allow function calls between files.
      d025f1e4
  6. 13 Oct, 2012 1 commit
    • Zbigniew Jędrzejewski-Szmek's avatar
      journald: properly update message size after stripping the identifier · e88baee8
      Zbigniew Jędrzejewski-Szmek authored
      Valgrind says:
      ==29176== Conditional jump or move depends on uninitialised value(s)
      ==29176==    at 0x412A85: cunescape_length_with_prefix (util.c:1565)
      ==29176==    by 0x40B351: dev_kmsg_record (journald-kmsg.c:301)
      ==29176==    by 0x40B653: server_read_dev_kmsg (journald-kmsg.c:347)
      ==29176==    by 0x40B701: server_flush_dev_kmsg (journald-kmsg.c:365)
      ==29176==    by 0x409DE7: main (journald.c:1535)
      e88baee8
  7. 17 Sep, 2012 1 commit
  8. 23 Aug, 2012 1 commit
  9. 22 Aug, 2012 3 commits