Unverified Commit ad474cb0 authored by Ben Schumacher's avatar Ben Schumacher Committed by GitHub
Browse files

[MM-18592] Add IconPath field to plugin manifest (#12189)

parent b43b8480
......@@ -130,6 +130,10 @@ type Manifest struct {
// A description of what your plugin is and does.
Description string `json:"description,omitempty" yaml:"description,omitempty"`
// A relative file path in the bundle that points to the plugins svg icon for use with the Plugin Marketplace.
// This should be relative to the root of your bundle and the location of the manifest file. Bitmap image formats are not supported.
IconPath string `json:"icon_path,omitempty" yaml:"icon_path,omitempty"`
// A version number for your plugin. Semantic versioning is recommended: http://semver.org
Version string `json:"version" yaml:"version"`
......@@ -64,6 +64,7 @@ func TestFindManifest(t *testing.T) {
func TestManifestUnmarshal(t *testing.T) {
expected := Manifest{
Id: "theid",
IconPath: "assets/icon.svg",
MinServerVersion: "5.6.0",
Server: &ManifestServer{
Executable: "theexecutable",
......@@ -102,6 +103,7 @@ func TestManifestUnmarshal(t *testing.T) {
var yamlResult Manifest
require.NoError(t, yaml.Unmarshal([]byte(`
id: theid
icon_path: assets/icon.svg
min_server_version: 5.6.0
executable: theexecutable
......@@ -131,7 +133,8 @@ settings_schema:
var jsonResult Manifest
require.NoError(t, json.Unmarshal([]byte(`{
"id": "theid",
"min_server_version": "5.6.0",
"icon_path": "assets/icon.svg",
"min_server_version": "5.6.0",
"server": {
"executable": "theexecutable",
"executables": {
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment