1. 30 Jul, 2018 3 commits
    • Martin Kraft's avatar
      Pr 9039 (#9187) · 5872bf9c
      Martin Kraft authored
      * MM-11065: Allow to search and get archived channels from the API
      
      * Fixing more tests
      
      * Add some unit tests
      
      * Add includeDeleted parameter to session permissions check function
      
      * More test fixing
      
      * Adding archive channels list in channels search
      
      * Add restriction for archived channel edition
      
      * Reverting permissions checks modification
      
      * Changed the query parameter to include_deleted
      
      * Enable search archive channels as true by default
      
      * Adding tests for verify search on deleted channels
      
      * Allowing to override archive channels during the imports
      
      * Fixed test
      
      * Search in archive channels from the API must be explicitly requested
      
      * Removing includeDeleted parameter from GetChannelByName and GetChannelByNameForTeam
      
      * Back to ViewArchivedChannels config
      
      * Fixing tests
      
      * Reverting GetChannelByName parameter
      
      * Add include deleted parameter on GetChannel functions in plugins api
      
      * Fixing tests
      5872bf9c
    • Martin Kraft's avatar
      MM-11301: Validates listen address config value. (#9138) · 65cd447a
      Martin Kraft authored
      * MM-11301: Validates listen address config value.
      
      * MM-11301: Adds some invalid port test cases.
      
      * MM-11301: Accept domain names.
      
      * MM-11301: Fix for max port.
      65cd447a
    • Daniel Schalla's avatar
      Login Hooks (#9177) · d23ca071
      Daniel Schalla authored
      Tests; gofmt
      d23ca071
  2. 28 Jul, 2018 2 commits
  3. 27 Jul, 2018 5 commits
    • Joram Wilander's avatar
      6ac82d51
    • Joram Wilander's avatar
      Fix compile error caused by bad merge (#9176) · 441c8741
      Joram Wilander authored
      * Fix compile error caused by bad merge
      
      * Fix
      
      * Fix
      441c8741
    • Jesse Hallam's avatar
      MM-11431: handle plugin deadlocks (#9167) · 835c0871
      Jesse Hallam authored
      * ensure plugin is always shutdown
      
      Once we call `.client.Client()` the plugin has started, and must be shut
      down. `newSupervisor` sometimes returned with an error (and without a
      reference to the supervisor), leaving the client running indefinitely.
      
      * Clarify the documentation to explain that plugin hooks will not trigger until `OnActivate` returns successfully, and will stop triggering just before `OnDeactivate` is called.
      
      * test for plugin deadlock
      
      * plugin/environment.go: switch to sync.Map
      
      From: https://golang.org/pkg/sync/#Map
      
      > If a goroutine holds a RWMutex for reading and another goroutine might call Lock, no goroutine should expect to be able to acquire a read lock until the initial read lock is released. In particular, this prohibits recursive read locking. This is to ensure that the lock eventually becomes available; a blocked Lock call excludes new readers from acquiring the lock.
      
      The previous `RWMutex` was not safe given that we effectively acquired read locks recursively (hook -> api -> hook). This worked up until we activated or deactivated plugins, tried to acquire a write lock, and the plugin used the API to effectively trigger another hook.
      
      Switching to sync.Map avoids this by divesting the need to lock at all, avoiding the potential for a recursive lock in the first place.
      835c0871
    • Jesse Hallam's avatar
      s/mlog/log/ in apiRPCClient (#9171) · 1d9c1448
      Jesse Hallam authored
      We never actually initialized `log` on apiRPCClient, and it can't log
      without making an RPC call anyway, so just switch to logging errors from
      the plugin to STDERR instead.
      1d9c1448
    • Christopher Speller's avatar
      Adding FileWillBeUploaded plugin hook (#9169) · 026f0152
      Christopher Speller authored
      * Adding file upload hook.
      
      * Adding hook test for FileWillBeUploaded
      
      * Some debugging fixes.
      
      * Fix typo.
      
      * Fixing double close
      
      * Fix capitalization on docs.
      026f0152
  4. 26 Jul, 2018 5 commits
  5. 25 Jul, 2018 2 commits
  6. 24 Jul, 2018 3 commits
  7. 23 Jul, 2018 3 commits
  8. 20 Jul, 2018 7 commits
  9. 19 Jul, 2018 4 commits
  10. 18 Jul, 2018 6 commits
    • Christopher Speller's avatar
      MM-11028 Adding some plugin tests. (#9103) · 5a2d46c6
      Christopher Speller authored
      * Rearranging plugin mocks and moving some common test code out.
      
      * Adding tests.
      
      * Fixing tests after GoDoc cleanup changes.
      5a2d46c6
    • Jesse Hallam's avatar
      Support `server`, deprecate `backend` in plugin manifest (#9127) · 309a3dda
      Jesse Hallam authored
      * Support `server`, deprecate `backend` in plugin manifest
      
      This lets us converge on the use of the term `server` everywhere instead
      of sometimes `backend` and sometimes `server`. We're still using
      `webapp` and will eventually support `mobile` as well.
      
      The plan is actually to rip out these deprecations as part of releasing
      5.2, but I want to coordinate the extra additional breakage at the same
      time, so for now this is a backwards compatible change.
      
      * fix failing tests
      309a3dda
    • Joram Wilander's avatar
    • Chris Duarte's avatar
      Support for Embeded chat (#9129) · 3fcecd52
      Chris Duarte authored
      * Add ucLive support
      
      crazy testing
      
      lovely logs
      
      more cookie work arounds
      
      Added Access-Control-Expose-Headers to user login
      
      Add complete_saml_body template and revert loginWithSaml endpoint
      
      Set Access-Control-Allow-Credentials to true in user login
      
      Login via email instead of username
      
      Clean up code
      
      Add comment to give some context
      
      Move faml logic into saml function
      
      Communicate via chrome sendMessage api
      
      Remove unused code
      
      Add config to support multiple extensions
      
      Clean up embedded complete_saml template
      
      Fix indentation for templates
      
      Added license header to extension.go
      
      Add EnableExperimentalExtensions flag
      
      Extension validated for email auth
      
      Clean up api auth code
      
      Remove complete_saml_body.html
      
      * Add extension support in saml
      
      * Clean up code
      
      * Clean up extension validation
      3fcecd52
    • Elias Nahum's avatar
      translations PR 20180718 (#9123) · 6b27b74f
      Elias Nahum authored
      6b27b74f
    • Jason Blais's avatar
      Update en.json (#9096) · 715de382
      Jason Blais authored
      715de382