1. 20 Apr, 2018 1 commit
  2. 19 Apr, 2018 3 commits
  3. 18 Apr, 2018 3 commits
  4. 17 Apr, 2018 8 commits
  5. 16 Apr, 2018 3 commits
  6. 14 Apr, 2018 3 commits
    • Derrick Anderson's avatar
      revert changes from MM9720 · 3176e13b
      Derrick Anderson authored
      3176e13b
    • Jesse Hallam's avatar
      Prevent disabling or modifying l4g logging filters (#8628) · 8056dc33
      Jesse Hallam authored
      The underlying l4g library is not resilient to filter modifications in
      the presence of concurrent goroutines. In particular, it's not safe to
      call Close() on filters which might be actively held by a goroutine for
      logging.
      
      This change disables all modifications to existing filters once
      initialized by the App layer. In practice, we might be able to get away
      with some modifications to the existing filters (i.e. changing levels),
      but the [golang memory model](https://golang.org/ref/mem) makes no
      guarantees that it is safe to do so:
      
      > Programs that modify data being simultaneously accessed by multiple goroutines must serialize such access.
      
      We can solve this holistically by introducing the requisite locking
      within our fork of the l4g library. For now, we just disable all
      modifications.
      8056dc33
    • Christopher Speller's avatar
  7. 13 Apr, 2018 5 commits
  8. 12 Apr, 2018 6 commits
  9. 11 Apr, 2018 1 commit
  10. 10 Apr, 2018 2 commits
  11. 09 Apr, 2018 3 commits
  12. 06 Apr, 2018 2 commits