GitLab

I believe we don't need to force downloading of shared public files, because `writeFileResponse` method will compare its MIME type with `MEDIA_CONTENT_TYPES` and output it inline or as attachment automatically.

Usually we are share images and it is much more convenient to see them without downloading.

* Move file backend to its own service

* Moving utils/inbucket to mailservice package

* Add ChannelId and TeamId to PostActionIntegrationRequest

* Add tests

This reverts commit 5786b0d6, now that
the feature is safe to enable by default.

Creating triggers requires SUPERUSER privileges, and is especially
painful on RDS. Pivot to maintaining this denormalized table in code.

* MM-11700 Clean up handling of user display names for notifications

* MM-11781: Basic Data Export Command Line.

* ChannelStore new unit tests.

* TeamStore new unit tests.

* Unit test for new UserStore function.

* Unit tests for post store new methods.

* Review fixes.

* Fix duplicate command name.

* disable EnablePublicChannelsMaterialization by default

Creating triggers on Amazon RDS seems to reqiure extra privileges. More
investigation is required.

* update model/config.go too

Refactored parseSlackAttachment functions from https://github.com/mattermost/mattermost-server/blob/master/app/post.go#L312
into model/slack_attachments.go so that plugins have access to them.

* MM-11424 Extend bulk import to support themes across teams(#9305)

Also added:
Advanced Settings:
+'feature_enabled_markdown_preview'
+'formatting'
Sidebar Settings:
+'show_unread_section'

* MM-11424 (PR review) user teams' theme validator test updated

* MM-11424 (PR review) added test with valid JSON of invalid theme(by structure)

JSON string contains numeric and JSON object fields, not just a correct "string":"string" map

* fixing log messages

* update per review

* Update notification.go

* Update server.go

* Update notification.go

* MM-11520: Make entity ID checks consistent across api4.

* Update tests.

* MM-11734: encode unregistered error implementations as an ErrorString

* MM-11734: test error string handling

* more idiomatic error handling

* materialize PublicChannels table

Introduce triggers for each supported database that automatically maintain a subset of the Channels table corresponding to only public channels. This improves corresponding queries that no longer need to filter out 99% DM channels.

This initial commit modifies the channel store directly for easier code reviewing, but the next wraps an experimental version around it to enable a kill switch in case there are unforeseen performance regressions.

This addresses [MM-11886](https://mattermost.atlassian.net/browse/MM-11886) and [MM-11945](https://mattermost.atlassian.net/browse/MM-11945).

* extract the experimental public channels materialization

Wrap the original channel store with an experimental version that
leverages the materialized public channels, but can be disabled to
fallback to the original implementation.

This addresses MM-11947.

* s/ExperimentalPublicChannelsMaterialization/EnablePublicChannelsMaterialization/

* simplify error handling

* move experimental config listener until after store is initialized

Also add additional unit tests to make sure the permissions tests are
completely solid.

* Minor grammar & spelling fixes

Minor grammar & spelling fixes

* Harmonizing error messages

First step to harmonize the error messges by using three formulations
that basically mean the same.

* Changed string after feedback.

* Change after feedback

* Removed typo

Head hit keyboard or something...

* Updated second occurence of an already changed string

Changed ssecond occurence of "Unable to know if the file exists. An error ocurred when trying to check file existence."

* MM-11855 Add App.HTTPService to allow mocking of HTTP client

* Initialize HTTPService earlier

This fixes an issue where the cached Channel objects would contain data
from a failed update when the update to the database failed.