• Jesse Hallam's avatar
    Fix various segfaults when running `go test` manually (#8448) · 9d701c70
    Jesse Hallam authored
    * failing to find i18n shouldn't segfault
    
    The server was trying to handle the fact that it couldn't find the i18n
    directory, by emitting a translated log message...
    
    * fix utils.FindDir
    
    The attempts to find the directory in the parent or grandparent directory
    don't work if the current working directory was inside `enterprise`, with
    `enterprise` itself being a symlink as per the usual developer setup.
    
    Recurse to the root of the filesystem, cleaning the path along the way
    to work around this limitation (and allow tests to be run from an
    arbitrarily deep nesting level.)
    
    Fix corresponding usages to employ filepath.Join.
    
    * failing to find html templates shouldn't segfault
    
    * fail fast if the test user cannot be created
    
    * rework utils.FindDir to retain backwards compatibility
    9d701c70