1. 25 Jun, 2018 1 commit
  2. 11 May, 2018 1 commit
    • Jesse Hallam's avatar
      fix mlog-ing before initialized (#8753) · b4db76ce
      Jesse Hallam authored
      Dump mlog to STDOUT before initialized, to allow for logging failures
      that occur due to config parsing, etc.
      
      Fix file logging to honour logger.FileJson instead of copying the
      logger.ConsoleJson setting.
      b4db76ce
  3. 10 May, 2018 1 commit
  4. 01 May, 2018 1 commit
    • Jesse Hallam's avatar
      MM-8622: improved plugin error handling (#8692) · 1e655370
      Jesse Hallam authored
      * don't report an error on plugin activation if already active
      
      * improved plugin logging events
      
      Log an error when a plugin's ServeHTTP fails, or when it unexpectedly
      terminates.
      
      Restart a plugin at most three times, allowing its failure to later
      bubble up under the "failed to stay running" status.
      
      * clarified plugin activation/deactivation
      
      Avoid repeatedly activating when any configuration bit changes. Improved
      logging.
      
      * constrain plugin ids to ^[a-zA-Z0-9-_\.]+$ and enforce minimum length
      
      Previously, the plugin id was used unsanitized to relocate the plugin
      bundle, which allowed writing outside the `plugins/` directory by using
      an `id` containing `../`.
      
      Similarly, an empty string was accepted as an id and led to unexpected
      error messages.
      
      * remove plugins by manifest path, not id
      
      If the id within the manifest ever diverges from the actual plugin
      location, it becomes impossible to remove via the API. Instead, if the
      plugin is found by id, remove the path containing the manifest.
      
      * ignore plugins with nil manifests
      
      If a plugin was detected, but had a manifest that couldn't be parsed, it
      will be left nil but still be listed among the packages. Skip over these
      in most cases to avoid segfaults.
      
      * leverage mlog more effectively for plugins
      
      * build issues
      1e655370
  5. 30 Apr, 2018 1 commit
  6. 27 Apr, 2018 1 commit
    • Christopher Speller's avatar
      Structured logging (#8673) · 686c2fba
      Christopher Speller authored
      * Implementing structured logging
      
      * Changes to en.json to allow refactor to run.
      
      * Fixing global logger
      
      * Structured logger initalization.
      
      * Add caller.
      
      * Do some log redirection.
      
      * Auto refactor
      
      * Cleaning up l4g reference and removing dependancy.
      
      * Removing junk.
      
      * Copyright headers.
      
      * Fixing tests
      
      * Revert "Changes to en.json to allow refactor to run."
      
      This reverts commit fd8249e99bcad0231e6ea65cd77c32aae9a54026.
      
      * Fixing some auto refactor strangeness and typo.
      
      * Making keys more human readable.
      686c2fba