Commit c2bc26f7 authored by Mike Rapoport's avatar Mike Rapoport Committed by Linus Torvalds

sparc32: use PUD rather than PGD to get PMD in srmmu_nocache_init()

The kbuild test robot reported the following warning:

  arch/sparc/mm/srmmu.c: In function 'srmmu_nocache_init': arch/sparc/mm/srmmu.c:300:9: error: variable 'pud' set but not used [-Werror=unused-but-set-variable]
  300 |  pud_t *pud;

This warning is caused by misprint in the page table traversal in
srmmu_nocache_init() function which accessed a PMD entry using PGD
rather than PUD.

Since sparc32 has only 3 page table levels, the PGD and PUD are
essentially the same and usage of __nocache_fix() removed the type

Use PUD for the consistency and to silence the compiler warning.

Fixes: 7235db26 ("sparc32: use pgtable-nopud instead of 4level-fixup")
Reported-by: default avatarkbuild test robot <>
Signed-off-by: default avatarMike Rapoport <>
Signed-off-by: default avatarAndrew Morton <>
Cc: David S. Miller <>
Cc: Anatoly Pugachev <>
Cc: <>
Link: default avatarLinus Torvalds <>
parent f7fa1876
......@@ -333,7 +333,7 @@ static void __init srmmu_nocache_init(void)
pgd = pgd_offset_k(vaddr);
p4d = p4d_offset(__nocache_fix(pgd), vaddr);
pud = pud_offset(__nocache_fix(p4d), vaddr);
pmd = pmd_offset(__nocache_fix(pgd), vaddr);
pmd = pmd_offset(__nocache_fix(pud), vaddr);
pte = pte_offset_kernel(__nocache_fix(pmd), vaddr);
pteval = ((paddr >> 4) | SRMMU_ET_PTE | SRMMU_PRIV);
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment