Skip to content
GitLab
  1. 13 Jan, 2023 1 commit
  3. 12 Jan, 2023 1 commit
  5. 24 Mar, 2022 1 commit
  7. 23 Mar, 2022 1 commit
  9. 28 Jan, 2022 1 commit
  11. 27 Jan, 2022 4 commits
  13. 18 Jan, 2022 1 commit
  15. 14 Jan, 2022 4 commits
  17. 06 Jan, 2022 3 commits
  19. 05 Jan, 2022 2 commits
  21. 10 Dec, 2021 1 commit
  23. 02 Dec, 2021 1 commit
    • James Addison's avatar
      Update to chrono-node v2.3.4 (#40) · b9206422
      James Addison authored 
      * Update to chrono-node v2.3.2

* Update import format

* Adjust reference message creation time format (moment -> Date)

* Remove prasedTime.tags checks; push en-language parser requirement down to parse() function call

* Add test coverage over newly-introduced chrono-node functionality: hour-only timezone offset parsing

* Ensure that the reference timestamp (retrieved from the message as unix epoch seconds) has an explicit empty timezone

* Add a workaround for the scenario where 'now' is identified as a timestamp-with-timezone during parsing

* lint fixup

* edit: fix incomplete sentence

* Ensure that chrono-node 'forwardDate' option is respected, by passing a reference date

Note that this seems to duplicate the 'instant' date also provided as a parser option

* Add test coverage over forward-date parsing for named weekdays

* Fixup: test expectation

* Pass null as reference timezone instead of an empty object

* Update to chrono-node v2.3.3

* Revert "Add a workaround for the scenario where 'now' is identified as a timestamp-with-timezone during parsing"

This reverts commit 6460d738.

* Extract timezone-offset-aware momentjs objects from chrono parsing results

* Cleanup: simplify chrono parsing options

* Fixup: separate parsing-reference-date and parsing-options into two separate objects

* Revert "Revert "Add a workaround for the scenario where 'now' is identified as a timestamp-with-timezone during parsing""

This reverts commit 39db146f.

* Add TODO note regarding unpicking the 'now' timezone handling workaround

* Remove explicit selection of en-language parser

* Add brief explanatory comment for chronoToMoment function

* Update to chrono-node v2.3.4

* Revert "Add TODO note regarding unpicking the 'now' timezone handling workaround"

This reverts commit 97d40d2a.

* Revert "Revert "Revert "Add a workaround for the scenario where 'now' is identified as a timestamp-with-timezone during parsing"""

This reverts commit b7da5ade.

* Remove chronoToMoment function

Please note: this was largely added as a workaround, as discussed at https://github.com/mattermost/mattermost-plugin-walltime/pull/40#discussion_r755360308

On balance, I think it's better to remove this function from the code to be maintained, even if edge cases remain.  Less code should generally be easier for people to reason about if & when we are digging into those edge cases in future

* Add test coverage from locally-applied Collabora hotfix to prove that the upgrade to chrono v2.3.4 avoids misinterpretation of the word 'ah' as a timestamp

Ref: !4
      b9206422
  25. 08 Sep, 2021 1 commit
    • James Addison's avatar
      Implement: support UTC during timezone name parsing (#38) · b5e8045f
      James Addison authored 
      * Add illustrative test case

* Use a strict undefined value check rather than a falsy check on parsed timezone offsets

* Fixup: use microseconds instead of milliseconds in the test reference timestamp

* linting: apply eslint in 'fix' mode

* linting / safety: use 'typeof' operator instead of 'undefined' keyword for value presence test
      b5e8045f
  27. 12 May, 2021 2 commits
  29. 11 Dec, 2020 1 commit
  31. 12 Nov, 2020 1 commit
  33. 30 Jul, 2020 1 commit
  35. 16 Jul, 2020 1 commit
  37. 26 Mar, 2020 1 commit
  39. 16 Mar, 2020 1 commit
  41. 30 Dec, 2019 1 commit
  43. 27 Aug, 2019 1 commit
  45. 23 Jul, 2019 1 commit
  47. 22 Jul, 2019 1 commit
  49. 21 Jul, 2019 1 commit
  51. 19 Jul, 2019 2 commits
  53. 17 Jul, 2019 1 commit
  55. 16 Jul, 2019 2 commits