Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • mattermost-profile-plus mattermost-profile-plus
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Tools
  • mattermost
  • mattermost-profile-plusmattermost-profile-plus
  • Merge requests
  • !13

Hide profile link when there is no URL

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Afonso Cerejeira requested to merge hide-profile-link-for-empty-url into main Nov 22, 2021
  • Overview 4
  • Commits 2
  • Pipelines 1
  • Changes 4

To prevent the bug described in T31606 we add a conditional check for the URL property before rendering the profile link.

You can check it out on the test instance, if you click on my profile, you'll notice that it will take a while before displaying the Touch profile link - that is the time of performing the request and waiting for the response. Previously we were rendering the URL even before we got a response from the API, so sometimes the link would be wrong.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: hide-profile-link-for-empty-url