 26 Sep, 2019 1 commit


Tapani Pälli authored
Fixes issues with 'eglgl_oes_egl_image' Piglit test. Signedoffby: Tapani Pälli <tapani.palli@intel.com> Reviewedby: Marek Olšák <marek.olsak@amd.com>

 25 Sep, 2019 39 commits


Dylan Baker authored
We want to generate PC files for nonglvnd builds and for builds with old glvnd, but the current logic doesn't do that, it builds them unconditionally, and for GLES it builds the shared libraries, which is also not what we want. This does not generate .pc files for gles1 or gles2. Which it we weren't doing before either, making this not a regression but a return to statusquo.o Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1838 Fixes: 93df862b ("meson: readd incorrect pkgconfig files with GLVND for backward compatibility") Reviewedby: Matt Turner <mattst88@gmail.com>

Ian Romanick authored
Reviewedby: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> All Gen7+ platforms had similar results. (Ice Lake shown) total instructions in shared programs: 16328255 > 16315391 (0.08%) instructions in affected programs: 218318 > 205454 (5.89%) helped: 988 HURT: 0 helped stats (abs) min: 1 max: 72 x̄: 13.02 x̃: 10 helped stats (rel) min: 0.33% max: 16.04% x̄: 6.27% x̃: 4.88% 95% mean confidence interval for instructions value: 13.69 12.35 95% mean confidence interval for instructions %change: 6.55% 5.99% Instructions are helped. total cycles in shared programs: 363683977 > 363615417 (0.02%) cycles in affected programs: 1475193 > 1406633 (4.65%) helped: 923 HURT: 36 helped stats (abs) min: 1 max: 624 x̄: 75.78 x̃: 48 helped stats (rel) min: 0.08% max: 13.89% x̄: 5.20% x̃: 5.08% HURT stats (abs) min: 1 max: 179 x̄: 38.58 x̃: 4 HURT stats (rel) min: 0.06% max: 16.56% x̄: 3.33% x̃: 0.29% 95% mean confidence interval for cycles value: 75.88 67.10 95% mean confidence interval for cycles %change: 5.10% 4.66% Cycles are helped. Sandy Bridge total instructions in shared programs: 10785779 > 10785654 (<.01%) instructions in affected programs: 13855 > 13730 (0.90%) helped: 67 HURT: 0 helped stats (abs) min: 1 max: 15 x̄: 1.87 x̃: 1 helped stats (rel) min: 0.20% max: 3.45% x̄: 0.97% x̃: 0.78% 95% mean confidence interval for instructions value: 2.47 1.26 95% mean confidence interval for instructions %change: 1.13% 0.81% Instructions are helped. total cycles in shared programs: 153704799 > 153704481 (<.01%) cycles in affected programs: 101509 > 101191 (0.31%) helped: 38 HURT: 13 helped stats (abs) min: 1 max: 38 x̄: 12.53 x̃: 16 helped stats (rel) min: 0.07% max: 2.69% x̄: 0.87% x̃: 0.53% HURT stats (abs) min: 1 max: 36 x̄: 12.15 x̃: 7 HURT stats (rel) min: 0.06% max: 2.53% x̄: 0.73% x̃: 0.44% 95% mean confidence interval for cycles value: 10.24 2.24 95% mean confidence interval for cycles %change: 0.75% 0.17% Cycles are helped. LOST: 2 GAINED: 0 No shaderdb change on Iron Lake or GM45.

Ian Romanick authored
This allows the reslut of mov and bcsel to be separately interpreted as float or int depending on the use. Reviewedby: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>

Ian Romanick authored
Some shaders are hurt by this change because now a load_const(0x00000000) is not recognized as eq_zero when loaded as a float. This behavior is restored in a later patch (nir/rangeanalysis: Use types to provide better ranges from bcsel and mov). v2: Add a comment about reinterpretation of int/uint/bool. Suggested by Caio. Rewrite condition the check for types being float versus checking for types not being all the things that aren't float. Fixes: 405de7cc ("nir/rangeanalysis: Rudimentary value range analysis pass") Reviewedby: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> All Gen7+ platforms had similar results. (Ice Lake shown) total instructions in shared programs: 16327543 > 16328255 (<.01%) instructions in affected programs: 55928 > 56640 (1.27%) helped: 0 HURT: 208 HURT stats (abs) min: 1 max: 16 x̄: 3.42 x̃: 3 HURT stats (rel) min: 0.33% max: 6.74% x̄: 1.31% x̃: 1.12% 95% mean confidence interval for instructions value: 3.06 3.79 95% mean confidence interval for instructions %change: 1.17% 1.46% Instructions are HURT. total cycles in shared programs: 363682759 > 363683977 (<.01%) cycles in affected programs: 325758 > 326976 (0.37%) helped: 44 HURT: 133 helped stats (abs) min: 1 max: 179 x̄: 33.61 x̃: 5 helped stats (rel) min: 0.06% max: 14.21% x̄: 2.47% x̃: 0.29% HURT stats (abs) min: 1 max: 157 x̄: 20.28 x̃: 14 HURT stats (rel) min: 0.07% max: 14.44% x̄: 1.42% x̃: 0.73% 95% mean confidence interval for cycles value: 0.38 13.39 95% mean confidence interval for cycles %change: 0.06% 0.96% Inconclusive result (%change mean confidence interval includes 0). Sandy Bridge total instructions in shared programs: 10787433 > 10787443 (<.01%) instructions in affected programs: 1842 > 1852 (0.54%) helped: 0 HURT: 10 HURT stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 HURT stats (rel) min: 0.33% max: 1.85% x̄: 0.73% x̃: 0.49% 95% mean confidence interval for instructions value: 1.00 1.00 95% mean confidence interval for instructions %change: 0.36% 1.10% Instructions are HURT. total cycles in shared programs: 153724543 > 153724563 (<.01%) cycles in affected programs: 8407 > 8427 (0.24%) helped: 1 HURT: 3 helped stats (abs) min: 18 max: 18 x̄: 18.00 x̃: 18 helped stats (rel) min: 0.98% max: 0.98% x̄: 0.98% x̃: 0.98% HURT stats (abs) min: 4 max: 18 x̄: 12.67 x̃: 16 HURT stats (rel) min: 0.21% max: 0.75% x̄: 0.56% x̃: 0.72% 95% mean confidence interval for cycles value: 21.31 31.31 95% mean confidence interval for cycles %change: 1.11% 1.46% Inconclusive result (value mean confidence interval includes 0). No shaderdb changes on Iron Lake or GM45.

Lionel Landwerlin authored
Commit bfc4c359b282 ("drm/i915/cml: Add Missing PCI IDs") in i915 added 3 new CML PCI ids. Signedoffby: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewedby: Kenneth Graunke <kenneth@whitecape.org>

Lionel Landwerlin authored
Fixes: 82f6a746 ("intel: Add support for Comet Lake") Signedoffby: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewedby: Kenneth Graunke <kenneth@whitecape.org>

Kristian H. Kristensen authored
Consolidate a few more generic shaders setup regs in fd6_emit_shader. Signedoffby: Kristian H. Kristensen <hoegsberg@google.com>

Kristian H. Kristensen authored
Signedoffby: Kristian H. Kristensen <hoegsberg@google.com>

Kristian H. Kristensen authored
Signedoffby: Kristian H. Kristensen <hoegsberg@google.com>

Kristian H. Kristensen authored
This add generic stage state setup for HS/DS/GS to the program state object. Signedoffby: Kristian H. Kristensen <hoegsberg@google.com>

Kristian H. Kristensen authored
Let's try to always order the stages in the pipeline order. Signedoffby: Kristian H. Kristensen <hoegsberg@google.com>

Kristian H. Kristensen authored
Signedoffby: Kristian H. Kristensen <hoegsberg@google.com>

Kristian H. Kristensen authored
We're using vs and fs now, and adding hs, ds and gs soon. It's confusing enough that we have both DS/TCS and HS/TES. At least for VS and FS there doesn't have to be multiple names. Signedoffby: Kristian H. Kristensen <hoegsberg@google.com>

Kristian H. Kristensen authored
We'll be sharing this logic for new shader stages soon. Signedoffby: Kristian H. Kristensen <hoegsberg@google.com>

Eric Engestrom authored
Signedoffby: Eric Engestrom <eric.engestrom@intel.com> Reviewedby: Erik FayeLund <erik.fayelund@collabora.com>

Eric Engestrom authored
Signedoffby: Eric Engestrom <eric.engestrom@intel.com> Reviewedby: Dylan Baker <dylan@pnwbakers.com>

Eric Engestrom authored
Signedoffby: Eric Engestrom <eric.engestrom@intel.com> Reviewedby: Dylan Baker <dylan@pnwbakers.com>

Lionel Landwerlin authored
Fixes invalid close(1) in the unit tests. Signedoffby: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesastable@lists.freedesktop.org> Reviewedby: Jason Ekstrand <jason@jlekstrand.net>

Danylo Piliaiev authored
RET as a last instruction could be safely ignored. Remove it to prevent crashes/warnings in case underlying driver doesn't implement arbitrary returns. A better way would be to remove the RET after the whole shader is parsed which will handle a possible case when the last RET is followed by a comment. CC: <mesastable@lists.freedesktop.org> Signedoffby: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewedby: Axel Davy <davyaxel0@gmail.com>

Dylan Baker authored
oneline shortens hashes, while oneline=pretty doesn't, otherwise they are the same. Having full hashes is convenient as that is the format that the bin/.cherryignore script requires to work correctly. Reviewedby: Eric Engestrom <eric.engestrom@intel.com> Reviewedby: Juan A. Suarez <jasuarez@igalia.com>

Dylan Baker authored
The main reason to do this is that 19.2 has slipped by two weeks, and such the 19.3 branch is due to happen extremely close to the release of 19.2.0. I think it would be better to have a little more time between releases for developers and for packagers. This would still have the 19.3 release out before December, even if it slips by 1 week. AckedBy: Karol Herbst <kherbst@redhat.com> Ackedby: Juan A. Suarez <jasuarez@igalia.com>

Dylan Baker authored

Dylan Baker authored

Dylan Baker authored

Andreas Baierl authored
Signedoffby: Andreas Baierl <ichgeh@imkreisrum.de> Reviewedby: Connor Abbott <cwabbott0@gmail.com>

Eric Engestrom authored
This is a bit counterintuitive, but the issue is that GLVND is broken in versions <= 1.1.1, so we need to keep wrongly providing these files to cover up their mistake, otherwise the rest of the world ends up broken. Suggestedby: Dylan Baker <dylan@pnwbakers.com> Cc: mesastable@lists.freedesktop.org Signedoffby: Eric Engestrom <eric.engestrom@intel.com> Reviewedby: Dylan Baker <dylan@pnwbakers.com>

Rhys Perry authored
Signedoffby: Rhys Perry <pendingchaos02@gmail.com> Reviewedby: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>

Rhys Perry authored
Fixes dEQPVK.glsl.builtin.function.integer.imulextended.*_compute Signedoffby: Rhys Perry <pendingchaos02@gmail.com> Reviewedby: Daniel Schürmann <daniel@schuermann.dev> Reviewedby: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>

Rhys Perry authored
Signedoffby: Rhys Perry <pendingchaos02@gmail.com> Reviewedby: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>

Rhys Perry authored
Fixes various dEQPVK.image.store.* tests. Signedoffby: Rhys Perry <pendingchaos02@gmail.com> Reviewedby: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>

Rhys Perry authored
We currently lower them, but nir_opt_algebraic() can add new ones because lower_sub=true. Signedoffby: Rhys Perry <pendingchaos02@gmail.com> Reviewedby: Daniel Schürmann <daniel@schuermann.dev>

Rhys Perry authored
nir_lower_idiv() asserts on 64bit integers. Signedoffby: Rhys Perry <pendingchaos02@gmail.com> Reviewedby: Daniel Schürmann <daniel@schuermann.dev>

Connor Abbott authored
When handling two variables with overlapping locations, we process the one with lower location first, and then extend the location > driver_location map to guarantee that it's contiguous for the second variable too. But the loop had the wrong bound, so we weren't extending the map 100%, which could lead to problems later such as an incorrect num_inputs. The loop index i is an index into the slots of the variable, so we need to stop at the final slot of the variable (var_size) instead of the number of unassigned slots. This fixes spec@arb_enhanced_layouts@execution@componentlayout@vsfsarrayinterleaverange on radeonsi NIR. Reviewedby: Marek Olšák <marek.olsak@amd.com>

Karol Herbst authored
Signedoffby: Karol Herbst <kherbst@redhat.com> Reviewedby: Pierre Moreau <dev@pmoreau.org>

Karol Herbst authored
Signedoffby: Karol Herbst <kherbst@redhat.com> Reviewedby: Pierre Moreau <dev@pmoreau.org>

Karol Herbst authored
both clang and gcc warn with: "moving a local object in a return statement prevents copy elision" Signedoffby: Karol Herbst <kherbst@redhat.com> Reviewedby: Pierre Moreau <dev@pmoreau.org>

Tapani Pälli authored
This moves the fix from commit 361f3d19 to happen in get_param (used now instead of get_handle by st/dri). This fixes artifacts seen with Xorg and CCS_E. Fixes: fc12fd05 "iris: Implement pipe_screen::resource_get_param" Signedoffby: Tapani Pälli <tapani.palli@intel.com> Reviewedby: Kenneth Graunke <kenneth@whitecape.org>

Erik FayeLund authored
Without this, we'll incorrectly round off huge values to the nearest representable double instead of keeping it at the exact value as we're supposed to. Found by inspecting compilerwarnings. Signedoffby: Erik FayeLund <erik.fayelund@collabora.com> Fixes: 85faf508 ("glsl: Add 64bit integer support for constant expressions") Reviewedby: Eric Engestrom <eric.engestrom@intel.com>

Vasily Khoruzhick authored
Utgard PP supports indirect load of uniforms and varyings, so let's enable it. Reviewedby: Qiang Yu <yuq825@gmail.com> Signedoffby: Vasily Khoruzhick <anarsoul@gmail.com>
