Commit d031d5c9 authored by Samuel Pitoiset's avatar Samuel Pitoiset

radv: enable primitive binning by default

After doing a bunch of benchmarks, primitive binning helps
some games like The Talos Principle (+5%) or Serious Sam 2017
(+3%). For other titles, either it doesn't change anything or
it hurts very few (less than 1%).

This only affects GFX9.
Signed-off-by: 's avatarSamuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: 's avatarBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
parent afd834b6
......@@ -57,9 +57,8 @@ enum {
RADV_PERFTEST_NO_BATCHCHAIN = 0x1,
RADV_PERFTEST_SISCHED = 0x2,
RADV_PERFTEST_LOCAL_BOS = 0x4,
RADV_PERFTEST_BINNING = 0x8,
RADV_PERFTEST_OUT_OF_ORDER = 0x10,
RADV_PERFTEST_DCC_MSAA = 0x20,
RADV_PERFTEST_OUT_OF_ORDER = 0x8,
RADV_PERFTEST_DCC_MSAA = 0x10,
};
bool
......
......@@ -466,7 +466,6 @@ static const struct debug_control radv_perftest_options[] = {
{"nobatchchain", RADV_PERFTEST_NO_BATCHCHAIN},
{"sisched", RADV_PERFTEST_SISCHED},
{"localbos", RADV_PERFTEST_LOCAL_BOS},
{"binning", RADV_PERFTEST_BINNING},
{"dccmsaa", RADV_PERFTEST_DCC_MSAA},
{NULL, 0}
};
......@@ -1633,9 +1632,7 @@ VkResult radv_CreateDevice(
}
device->pbb_allowed = device->physical_device->rad_info.chip_class >= GFX9 &&
((device->instance->perftest_flags & RADV_PERFTEST_BINNING) ||
device->physical_device->rad_info.family == CHIP_RAVEN ||
device->physical_device->rad_info.family == CHIP_RAVEN2);
!(device->instance->debug_flags & RADV_DEBUG_NOBINNING);
/* Disabled and not implemented for now. */
device->dfsm_allowed = device->pbb_allowed &&
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment