Commits · 3ff41ae3848c3c454f1b2c9fec6ef62509ce979a · virgl-es / virglrenderer

10 Feb, 2016 37 commits

renderer: fix potential leaks in vrend_create_shader · 3ff41ae3
Marc-André Lureau authored Jan 21, 2016
```
Found thanks to llvm scan-build.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
```
3ff41ae3

renderer: check create_shader() finished · 4f9a3636

Marc-André Lureau authored Jan 21, 2016

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

4f9a3636

renderer: fix sampler views leaks · 1e67b391

Marc-André Lureau authored Jan 21, 2016

Fix found thanks to AddressSanitizer.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

1e67b391

renderer: fix subcontext surface leaks · 595038e5

Marc-André Lureau authored Jan 21, 2016

Fix leaks found thanks to AddressSanitizer.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

595038e5

renderer: tinitial abs_s1 value is never read · 97ce5ea3
Marc-André Lureau authored Jan 20, 2016
```
Found thanks to llvm scan-build.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
```
97ce5ea3

decode: fix set_scissor_state bounds · ec24bd22

Marc-André Lureau authored Jan 20, 2016

Do not accept negative values for num & start.

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

ec24bd22

decode: check set_uniform_buffer arguments · 78f8994a

Marc-André Lureau authored Jan 20, 2016

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

78f8994a

decode: check set_sampler_views args · 3c0a03de

Marc-André Lureau authored Jan 20, 2016

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

3c0a03de

renderer: check box bounds · 9be86b89

Marc-André Lureau authored Jan 20, 2016

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

9be86b89

renderer: validate desc · 901b77d2

Marc-André Lureau authored Jan 19, 2016

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

901b77d2

renderer: over-allocate shader buffer · 04390599

Marc-André Lureau authored Jan 21, 2016

Since the memcpy() is done over multiple of 4 bytes, over-allocate the
destination buffer to fit multiple of 4 shader length.

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

04390599

renderer: check shader continuation fits · e215bde7

Marc-André Lureau authored Jan 21, 2016

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

e215bde7

renderer: prevent out of bound vps access · bfa6cd74

Marc-André Lureau authored Jan 19, 2016

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

bfa6cd74

renderer: avoid out of bound sampler array access · 18e4808c
Marc-André Lureau authored Jan 19, 2016
```
Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
```
18e4808c

renderer: validate shader_type value · 775f5ed6

Marc-André Lureau authored Jan 19, 2016

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

775f5ed6

vtest: ensure name is ending with 0 · ddb49b59

Marc-André Lureau authored Jan 21, 2016

Always nice to have.

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

ddb49b59

vtest: fix simple potential leaks · 0f01f30f

Marc-André Lureau authored Jan 21, 2016

Found thanks to llvm scan-build.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

0f01f30f

vtest: fix some leaks on error · 1edf354b

Marc-André Lureau authored Jan 18, 2016

Found thanks to llvm scan-build.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

1edf354b

vtest: allow to save/replay tests · 1b736c54

Marc-André Lureau authored Jan 16, 2016

This is useful to do some quite accurate comparative
benchmarks/profiling, and to run fuzzers, such as american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

1b736c54

decode: validate shader type · 36492a40

Marc-André Lureau authored Jan 19, 2016

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

36492a40

renderer: reject large LOD values · ad4f0f19

Marc-André Lureau authored Jan 19, 2016

Or we could sit for a very long time in some further loops.

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

ad4f0f19

renderer: report error on invalid surface · f58e985a

Marc-André Lureau authored Jan 19, 2016

Instead of later crashing.

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

f58e985a

renderer: validate scissor state index · b079de61

Marc-André Lureau authored Jan 19, 2016

Check the the index is < PIPE_MAX_VIEWPORTS.

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

b079de61

decode: check we don't reach MAX_VIEWPORTS · 2aa6c5bc

Marc-André Lureau authored Jan 19, 2016

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

2aa6c5bc

renderer: avoid crash in vrend_destroy_shader_selector() · e0e423aa

Marc-André Lureau authored Jan 19, 2016

If we didn't run succesfully vrend_destroy_shader_selector(),
sel->sinfo.so_names might be NULL.

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

e0e423aa

renderer: validate num_so_outputs · 9033b269

Marc-André Lureau authored Jan 19, 2016

Avoid out-of-bound acces of array so_info.output.

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

9033b269

renderer: use a uint32_t for shader type · 3767dbf1

Marc-André Lureau authored Jan 19, 2016

That way an value if (type > PIPE_SHADER_GEOMETRY) guard will actually
work for all values.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

3767dbf1

renderer: fix some vrend_sub_context leaks · 6a73ddfc

Marc-André Lureau authored Jan 18, 2016

Fix leaks found thanks to AddressSanitizer.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

6a73ddfc

renderer: do not accept invalid format · 0cb1bd0f

Marc-André Lureau authored Jan 18, 2016

That would later crash in util_format_description() or others

Fix found thanks to american fuzzy lop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

0cb1bd0f

renderer: fix potential leak · 2a4d35b8

Marc-André Lureau authored Jan 20, 2016

Found thanks to llvm scan-build.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

2a4d35b8

renderer: fix potential leak · 8030fdbd

Marc-André Lureau authored Jan 20, 2016

Found thanks to llvm scan-build.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

8030fdbd

shader: fix potential leak · 2c608122

Marc-André Lureau authored Jan 20, 2016

Found thanks to llvm scan-build.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

2c608122

vtest: fix vtestname leak · 602e6870

Marc-André Lureau authored Jan 18, 2016

Fix leaks found thanks to AddressSanitizer.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

602e6870

tests: use checked fixture · e1eef9a7

Marc-André Lureau authored Jan 21, 2016

The checked fixture run in the child test process.

Fix leaks found thanks to AddressSanitizer.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

e1eef9a7

Fix os-time.h removal · c54e1a76

Marc-André Lureau authored Feb 02, 2016

Commit 5058068a actually removed os/os_misc.h from libgallium_la_SOURCES
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

c54e1a76

renderer: fix eventfd check · 1795f9ca
Marc-André Lureau authored Jan 31, 2016
```
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
```
1795f9ca

renderer: destroy cond/mutex · 51bf7603

Marc-André Lureau authored Feb 04, 2016

For completeness (there is no dynamic allocation on Linux).
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

51bf7603

29 Jan, 2016 3 commits
- decode: prevent handle 0 object creation · bc358da3
  Marc-André Lureau authored Jan 19, 2016
```
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
```
  bc358da3
- vrend: fix potential crash with resource 0 creation · fbee79ae
  Marc-André Lureau authored Jan 18, 2016
```
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
```
  fbee79ae
- vrend: do not accept to insert resource 0 · 11464687
  Marc-André Lureau authored Jan 18, 2016
```
These leads to later crashes
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
```
  11464687