process_singleton_browsertest.cc 13.1 KB
Newer Older
1
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 3 4 5 6 7
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// This test validates that the ProcessSingleton class properly makes sure
// that there is only one main browser process.
//
8 9 10 11
// It is currently compiled and run on Windows and Posix(non-Mac) platforms.
// Mac uses system services and ProcessSingletonMac is a noop.  (Maybe it still
// makes sense to test that the system services are giving the behavior we
// want?)
12

13 14
#include <stddef.h>

15
#include "base/bind.h"
16
#include "base/command_line.h"
17
#include "base/files/file_path.h"
18
#include "base/files/scoped_temp_dir.h"
19
#include "base/location.h"
20
#include "base/macros.h"
21
#include "base/memory/ref_counted.h"
22
#include "base/memory/scoped_ptr.h"
23
#include "base/path_service.h"
24
#include "base/process/launch.h"
25
#include "base/process/process.h"
26
#include "base/process/process_iterator.h"
27
#include "base/single_thread_task_runner.h"
28
#include "base/synchronization/waitable_event.h"
29 30
#include "base/test/test_timeouts.h"
#include "base/threading/thread.h"
31
#include "build/build_config.h"
32
#include "chrome/common/chrome_constants.h"
33
#include "chrome/common/chrome_paths.h"
34
#include "chrome/common/chrome_switches.h"
35
#include "chrome/test/base/in_process_browser_test.h"
36
#include "chrome/test/base/test_launcher_utils.h"
37 38 39 40 41 42

namespace {

// This is for the code that is to be ran in multiple threads at once,
// to stress a race condition on first process start.
// We use the thread safe ref counted base class so that we can use the
43
// base::Bind to run the StartChrome methods in many threads.
44 45
class ChromeStarter : public base::RefCountedThreadSafe<ChromeStarter> {
 public:
46
  ChromeStarter(base::TimeDelta timeout, const base::FilePath& user_data_dir)
47 48
      : ready_event_(false /* manual */, false /* signaled */),
        done_event_(false /* manual */, false /* signaled */),
49
        process_terminated_(false),
50
        timeout_(timeout),
51
        user_data_dir_(user_data_dir) {
52 53 54 55 56 57 58
  }

  // We must reset some data members since we reuse the same ChromeStarter
  // object and start/stop it a few times. We must start fresh! :-)
  void Reset() {
    ready_event_.Reset();
    done_event_.Reset();
59 60
    if (process_.IsValid())
      process_.Close();
61 62 63
    process_terminated_ = false;
  }

64 65 66
  void StartChrome(base::WaitableEvent* start_event, bool first_run) {
    // TODO(mattm): maybe stuff should be refactored to use
    // UITest::LaunchBrowserHelper somehow?
67
    base::FilePath program;
68
    ASSERT_TRUE(PathService::Get(base::FILE_EXE, &program));
69
    base::CommandLine command_line(program);
70
    command_line.AppendSwitchPath(switches::kUserDataDir, user_data_dir_);
71 72

    if (first_run)
73
      command_line.AppendSwitch(switches::kForceFirstRun);
74 75
    else
      command_line.AppendSwitch(switches::kNoFirstRun);
76

77 78
    // Add the normal test-mode switches, except for the ones we're adding
    // ourselves.
79
    base::CommandLine standard_switches(base::CommandLine::NO_PROGRAM);
80
    test_launcher_utils::PrepareBrowserCommandLineForTests(&standard_switches);
81 82 83
    const base::CommandLine::SwitchMap& switch_map =
        standard_switches.GetSwitches();
    for (base::CommandLine::SwitchMap::const_iterator i = switch_map.begin();
84 85 86
         i != switch_map.end(); ++i) {
      const std::string& switch_name = i->first;
      if (switch_name == switches::kUserDataDir ||
87
          switch_name == switches::kForceFirstRun ||
88 89 90 91 92 93
          switch_name == switches::kNoFirstRun)
        continue;

      command_line.AppendSwitchNative(switch_name, i->second);
    }

94 95 96 97 98
    // Try to get all threads to launch the app at the same time.
    // So let the test know we are ready.
    ready_event_.Signal();
    // And then wait for the test to tell us to GO!
    ASSERT_NE(static_cast<base::WaitableEvent*>(NULL), start_event);
99
    start_event->Wait();
100 101 102 103

    // Here we don't wait for the app to be terminated because one of the
    // process will stay alive while the others will be restarted. If we would
    // wait here, we would never get a handle to the main process...
104 105
    process_ = base::LaunchProcess(command_line, base::LaunchOptions());
    ASSERT_TRUE(process_.IsValid());
106 107 108 109

    // We can wait on the handle here, we should get stuck on one and only
    // one process. The test below will take care of killing that process
    // to unstuck us once it confirms there is only one.
rvargas's avatar
rvargas committed
110 111
    int exit_code;
    process_terminated_ = process_.WaitForExitWithTimeout(timeout_, &exit_code);
112 113 114 115 116 117 118
    // Let the test know we are done.
    done_event_.Signal();
  }

  // Public access to simplify the test code using them.
  base::WaitableEvent ready_event_;
  base::WaitableEvent done_event_;
119
  base::Process process_;
120 121 122 123
  bool process_terminated_;

 private:
  friend class base::RefCountedThreadSafe<ChromeStarter>;
124

125
  ~ChromeStarter() {}
126

127
  base::TimeDelta timeout_;
128
  base::FilePath user_data_dir_;
129

130 131 132
  DISALLOW_COPY_AND_ASSIGN(ChromeStarter);
};

133 134
}  // namespace

135
// Our test fixture that initializes and holds onto a few global vars.
136
class ProcessSingletonTest : public InProcessBrowserTest {
137
 public:
138
  ProcessSingletonTest()
139 140 141
      // We use a manual reset so that all threads wake up at once when signaled
      // and thus we must manually reset it for each attempt.
      : threads_waker_(true /* manual */, false /* signaled */) {
142
    EXPECT_TRUE(temp_profile_dir_.CreateUniqueTempDir());
143 144
  }

145
  void SetUp() override {
146
    InProcessBrowserTest::SetUp();
147 148 149 150
    // Start the threads and create the starters.
    for (size_t i = 0; i < kNbThreads; ++i) {
      chrome_starter_threads_[i].reset(new base::Thread("ChromeStarter"));
      ASSERT_TRUE(chrome_starter_threads_[i]->Start());
151
      chrome_starters_[i] = new ChromeStarter(
152
          TestTimeouts::action_max_timeout(), temp_profile_dir_.path());
153 154 155
    }
  }

156
  void TearDown() override {
157 158 159 160 161 162 163 164 165 166 167 168 169
    // Stop the threads.
    for (size_t i = 0; i < kNbThreads; ++i)
      chrome_starter_threads_[i]->Stop();
  }

  // This method is used to make sure we kill the main browser process after
  // all of its child processes have successfully attached to it. This was added
  // when we realized that if we just kill the parent process right away, we
  // sometimes end up with dangling child processes. If we Sleep for a certain
  // amount of time, we are OK... So we introduced this method to avoid a
  // flaky wait. Instead, we kill all descendants of the main process after we
  // killed it, relying on the fact that we can still get the parent id of a
  // child process, even when the parent dies.
rvargas's avatar
rvargas committed
170
  void KillProcessTree(const base::Process& process) {
171 172 173 174 175
    class ProcessTreeFilter : public base::ProcessFilter {
     public:
      explicit ProcessTreeFilter(base::ProcessId parent_pid) {
        ancestor_pids_.insert(parent_pid);
      }
176
      bool Includes(const base::ProcessEntry& entry) const override {
177 178
        if (ancestor_pids_.find(entry.parent_pid()) != ancestor_pids_.end()) {
          ancestor_pids_.insert(entry.pid());
179 180 181 182 183 184 185
          return true;
        } else {
          return false;
        }
      }
     private:
      mutable std::set<base::ProcessId> ancestor_pids_;
rvargas's avatar
rvargas committed
186
    } process_tree_filter(process.Pid());
187 188 189

    // Start by explicitly killing the main process we know about...
    static const int kExitCode = 42;
rvargas's avatar
rvargas committed
190
    EXPECT_TRUE(process.Terminate(kExitCode, true /* wait */));
191 192 193 194 195

    // Then loop until we can't find any of its descendant.
    // But don't try more than kNbTries times...
    static const int kNbTries = 10;
    int num_tries = 0;
196
    base::FilePath program;
197
    ASSERT_TRUE(PathService::Get(base::FILE_EXE, &program));
198
    base::FilePath::StringType exe_name = program.BaseName().value();
199 200 201
    while (base::GetProcessCount(exe_name, &process_tree_filter) > 0 &&
           num_tries++ < kNbTries) {
      base::KillProcesses(exe_name, kExitCode, &process_tree_filter);
202 203 204 205 206 207 208 209 210 211 212 213
    }
    DLOG_IF(ERROR, num_tries >= kNbTries) << "Failed to kill all processes!";
  }

  // Since this is a hard to reproduce problem, we make a few attempts.
  // We stop the attempts at the first error, and when there are no errors,
  // we don't time-out of any wait, so it executes quite fast anyway.
  static const size_t kNbAttempts = 5;

  // The idea is to start chrome from multiple threads all at once.
  static const size_t kNbThreads = 5;
  scoped_refptr<ChromeStarter> chrome_starters_[kNbThreads];
214
  std::unique_ptr<base::Thread> chrome_starter_threads_[kNbThreads];
215 216 217 218

  // The event that will get all threads to wake up simultaneously and try
  // to start a chrome process at the same time.
  base::WaitableEvent threads_waker_;
219 220 221

  // We don't want to use the default profile, but can't use UITest's since we
  // don't use UITest::LaunchBrowser.
222
  base::ScopedTempDir temp_profile_dir_;
223 224
};

225 226 227
// Disabled on all platforms after code rot due to http://crbug.com/513534.
// Originally disabled on some platforms due to http://crbug.com/58219.
IN_PROC_BROWSER_TEST_F(ProcessSingletonTest, DISABLED_StartupRaceCondition) {
228 229 230 231 232 233 234 235
  // We use this to stop the attempts loop on the first failure.
  bool failed = false;
  for (size_t attempt = 0; attempt < kNbAttempts && !failed; ++attempt) {
    SCOPED_TRACE(testing::Message() << "Attempt: " << attempt << ".");
    // We use a single event to get all threads to do the AppLaunch at the same
    // time...
    threads_waker_.Reset();

236 237 238 239 240 241 242 243 244 245 246 247 248 249
    // Test both with and without the first-run dialog, since they exercise
    // different paths.
#if defined(OS_POSIX)
    // TODO(mattm): test first run dialog singleton handling on linux too.
    // On posix if we test the first run dialog, GracefulShutdownHandler gets
    // the TERM signal, but since the message loop isn't running during the gtk
    // first run dialog, the ShutdownDetector never handles it, and KillProcess
    // has to time out (60 sec!) and SIGKILL.
    bool first_run = false;
#else
    // Test for races in both regular start up and first run start up cases.
    bool first_run = attempt % 2;
#endif

250 251 252 253 254 255 256
    // Here we prime all the threads with a ChromeStarter that will wait for
    // our signal to launch its chrome process.
    for (size_t i = 0; i < kNbThreads; ++i) {
      ASSERT_NE(static_cast<ChromeStarter*>(NULL), chrome_starters_[i].get());
      chrome_starters_[i]->Reset();

      ASSERT_TRUE(chrome_starter_threads_[i]->IsRunning());
257
      ASSERT_NE(static_cast<base::MessageLoop*>(NULL),
258 259
                chrome_starter_threads_[i]->message_loop());

260 261 262 263
      chrome_starter_threads_[i]->task_runner()->PostTask(
          FROM_HERE,
          base::Bind(&ChromeStarter::StartChrome, chrome_starters_[i].get(),
                     &threads_waker_, first_run));
264 265 266 267 268 269
    }

    // Wait for all the starters to be ready.
    // We could replace this loop if we ever implement a WaitAll().
    for (size_t i = 0; i < kNbThreads; ++i) {
      SCOPED_TRACE(testing::Message() << "Waiting on thread: " << i << ".");
270
      chrome_starters_[i]->ready_event_.Wait();
271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297
    }
    // GO!
    threads_waker_.Signal();

    // As we wait for all threads to signal that they are done, we remove their
    // index from this vector so that we get left with only the index of
    // the thread that started the main process.
    std::vector<size_t> pending_starters(kNbThreads);
    for (size_t i = 0; i < kNbThreads; ++i)
      pending_starters[i] = i;

    // We use a local array of starter's done events we must wait on...
    // These are collected from the starters that we have not yet been removed
    // from the pending_starters vector.
    base::WaitableEvent* starters_done_events[kNbThreads];
    // At the end, "There can be only one" main browser process alive.
    while (pending_starters.size() > 1) {
      SCOPED_TRACE(testing::Message() << pending_starters.size() <<
                   " starters left.");
      for (size_t i = 0; i < pending_starters.size(); ++i) {
        starters_done_events[i] =
            &chrome_starters_[pending_starters[i]]->done_event_;
      }
      size_t done_index = base::WaitableEvent::WaitMany(
          starters_done_events, pending_starters.size());
      size_t starter_index = pending_starters[done_index];
      // If the starter is done but has not marked itself as terminated,
rvargas's avatar
rvargas committed
298 299
      // it is because it timed out of its WaitForExitCodeWithTimeout(). Only
      // the last one standing should be left waiting... So we failed...
300 301 302 303 304 305 306
      EXPECT_TRUE(chrome_starters_[starter_index]->process_terminated_ ||
                  failed) << "There is more than one main process.";
      if (!chrome_starters_[starter_index]->process_terminated_) {
        // This will stop the "for kNbAttempts" loop.
        failed = true;
        // But we let the last loop turn finish so that we can properly
        // kill all remaining processes. Starting with this one...
307
        if (chrome_starters_[starter_index]->process_.IsValid()) {
rvargas's avatar
rvargas committed
308
          KillProcessTree(chrome_starters_[starter_index]->process_);
309 310 311 312 313 314 315 316
        }
      }
      pending_starters.erase(pending_starters.begin() + done_index);
    }

    // "There can be only one!" :-)
    ASSERT_EQ(static_cast<size_t>(1), pending_starters.size());
    size_t last_index = pending_starters.front();
317
    pending_starters.clear();
318
    if (chrome_starters_[last_index]->process_.IsValid()) {
rvargas's avatar
rvargas committed
319
      KillProcessTree(chrome_starters_[last_index]->process_);
320 321 322 323
      chrome_starters_[last_index]->done_event_.Wait();
    }
  }
}