Skip to content
  • yukishiino's avatar
    Revert of binding: Removes Document::wrap that must be equivalent to... · 37245cec
    yukishiino authored
    Revert of binding: Removes Document::wrap that must be equivalent to Node::wrap. (patchset #5 id:100001 of https://codereview.chromium.org/2525313004/ )
    
    Reason for revert:
    CHECK(!frame->document()->containsWrapper()); in WindowProxy::updateDocumentProperty() is causing crashes at several places.
    
    Original issue's description:
    > binding: Removes Document::wrap that must be equivalent to Node::wrap.
    >
    > Removes unnecessary Document::wrap and associateWithWrapper.
    > The special code in these functions were made in order to keep
    > WindowProxy::m_document updated and consistent with toV8(document).
    > But we no longer rely on the hack, and we can remove the dead code.
    >
    > BUG=
    >
    > Committed: https://crrev.com/87dc599743f71d33466ac56a8db5a53c5f6ce46c
    > Cr-Commit-Position: refs/heads/master@{#435226}
    
    TBR=haraken@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=669968
    
    Review-Url: https://codereview.chromium.org/2538403002
    Cr-Commit-Position: refs/heads/master@{#435565}
    37245cec