-
grt authored
Revert of Windows install_static refactor. (patchset #15 id:320001 of https://codereview.chromium.org/2422643002/ ) Reason for revert: Causes a crash at uninstall; see https://crbug.com/663703. Original issue's description: > Windows install_static refactor. > > This change introduces install_static::InstallDetails, a module-global > holder of details relating to the current install. It also more clearly > defines the concept of a primary install mode and one or more secondary > install modes (e.g., "Chrome SxS" for Google Chrome's canary channel). > Furthermore, it creates a clear boundary for brand-specific constants so > that Chromium and Google Chrome don't bleed into one another. See > chrome/install_static/README.md for more information. > > BUG=373987 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng > > Committed: https://crrev.com/92bc27b8b101d2b300a7b3afd79265b3cfba1152 > Cr-Commit-Position: refs/heads/master@{#430728} TBR=ananta@chromium.org,robertshield@chromium.org,siggi@chromium.org,pennymac@chromium.org,thakis@chromium.org,bradnelson@chromium.org,phajdan.jr@chromium.org,dschuff@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=373987 Review-Url: https://codereview.chromium.org/2491463002 Cr-Commit-Position: refs/heads/master@{#430914}
51c82a0a