Skip to content
  • thakis@chromium.org's avatar
    Change the way _EXPORT macros look. · b387864d
    thakis@chromium.org authored
    With the current setup, if you have a header file my_class.h
    
    class BASE_EXPORT MyClass {
     public:
      void MyInlineMethod() { /* do stuff, inline */ }
    };
    
    then every cc file that includes my_class.h will have a public symbol
    for MyInlineMethod (because inline methods need to be emitted to
    every translation unit, and the linker sorts them out). With the
    components build, the linker can't decide to drop these inline methods,
    so every .so that uses this header file will have the same public symbol.
    
    With this proposed change, the symbol will only be visible in the target
    the header file belongs to, and it will be hidden in all other components.
    That's cleaner, and it also prevents accident hidden dependencies (say
    target A depends on B, and B depends on C. A accidentally uses an inline
    function from a class in C. With this change, that would result in a linker
    error, and an explicit dependency from A on C would have to be added).
    
    Also add a missing CHROMEOS_IMPLEMENTATION define which went
    unnoticed until now.
    
    BUG=90078
    TEST=Things still build.
    TBR=ben, tony, viettrungluu, thestig, agl, willchan
    
    Review URL: https://chromiumcodereview.appspot.com/10386108
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137130 0039d316-1c4b-4281-b951-d872f2087c98
    b387864d