Commit 8ed6f86e authored by vmpstr's avatar vmpstr Committed by Commit bot

gin: Add out-of-line copy ctors for complex classes.

This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.

BUG=436357
R=aa@chromium.org, dcheng@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1727063002

Cr-Commit-Position: refs/heads/master@{#377655}
parent a30521d9
......@@ -16,6 +16,8 @@ Dictionary::Dictionary(v8::Isolate* isolate,
object_(object) {
}
Dictionary::Dictionary(const Dictionary& other) = default;
Dictionary::~Dictionary() {
}
......
......@@ -26,6 +26,7 @@ class GIN_EXPORT Dictionary {
public:
explicit Dictionary(v8::Isolate* isolate);
Dictionary(v8::Isolate* isolate, v8::Local<v8::Object> object);
Dictionary(const Dictionary& other);
~Dictionary();
static Dictionary CreateEmpty(v8::Isolate* isolate);
......
......@@ -145,6 +145,9 @@ ObjectTemplateBuilder::ObjectTemplateBuilder(v8::Isolate* isolate)
template_->SetInternalFieldCount(kNumberOfInternalFields);
}
ObjectTemplateBuilder::ObjectTemplateBuilder(
const ObjectTemplateBuilder& other) = default;
ObjectTemplateBuilder::~ObjectTemplateBuilder() {
}
......
......@@ -89,6 +89,7 @@ struct CallbackTraits<v8::Local<v8::FunctionTemplate> > {
class GIN_EXPORT ObjectTemplateBuilder {
public:
explicit ObjectTemplateBuilder(v8::Isolate* isolate);
ObjectTemplateBuilder(const ObjectTemplateBuilder& other);
~ObjectTemplateBuilder();
// It's against Google C++ style to return a non-const ref, but we take some
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment