Commit 9e289b3d authored by sashab's avatar sashab Committed by Commit bot

Remove redundant WebLocalFrame* parameter from WillReleaseScriptContext

Remove redundant WebLocalFrame* parameter from WillReleaseScriptContext
in WebFrameClient.

BUG=361765

Review-Url: https://codereview.chromium.org/2838503002
Cr-Commit-Position: refs/heads/master@{#467259}
parent 5f758d23
...@@ -4616,11 +4616,8 @@ void RenderFrameImpl::DidCreateScriptContext(blink::WebLocalFrame* frame, ...@@ -4616,11 +4616,8 @@ void RenderFrameImpl::DidCreateScriptContext(blink::WebLocalFrame* frame,
observer.DidCreateScriptContext(context, world_id); observer.DidCreateScriptContext(context, world_id);
} }
void RenderFrameImpl::WillReleaseScriptContext(blink::WebLocalFrame* frame, void RenderFrameImpl::WillReleaseScriptContext(v8::Local<v8::Context> context,
v8::Local<v8::Context> context,
int world_id) { int world_id) {
DCHECK_EQ(frame_, frame);
for (auto& observer : observers_) for (auto& observer : observers_)
observer.WillReleaseScriptContext(context, world_id); observer.WillReleaseScriptContext(context, world_id);
} }
......
...@@ -627,8 +627,7 @@ class CONTENT_EXPORT RenderFrameImpl ...@@ -627,8 +627,7 @@ class CONTENT_EXPORT RenderFrameImpl
void DidCreateScriptContext(blink::WebLocalFrame* frame, void DidCreateScriptContext(blink::WebLocalFrame* frame,
v8::Local<v8::Context> context, v8::Local<v8::Context> context,
int world_id) override; int world_id) override;
void WillReleaseScriptContext(blink::WebLocalFrame* frame, void WillReleaseScriptContext(v8::Local<v8::Context> context,
v8::Local<v8::Context> context,
int world_id) override; int world_id) override;
void DidChangeScrollOffset() override; void DidChangeScrollOffset() override;
void WillInsertBody(blink::WebLocalFrame* frame) override; void WillInsertBody(blink::WebLocalFrame* frame) override;
......
...@@ -212,8 +212,7 @@ void LocalFrameClientImpl::WillReleaseScriptContext( ...@@ -212,8 +212,7 @@ void LocalFrameClientImpl::WillReleaseScriptContext(
v8::Local<v8::Context> context, v8::Local<v8::Context> context,
int world_id) { int world_id) {
if (web_frame_->Client()) { if (web_frame_->Client()) {
web_frame_->Client()->WillReleaseScriptContext(web_frame_, context, web_frame_->Client()->WillReleaseScriptContext(context, world_id);
world_id);
} }
} }
......
...@@ -4474,12 +4474,10 @@ class ContextLifetimeTestWebFrameClient ...@@ -4474,12 +4474,10 @@ class ContextLifetimeTestWebFrameClient
WTF::MakeUnique<Notification>(frame, context, world_id)); WTF::MakeUnique<Notification>(frame, context, world_id));
} }
void WillReleaseScriptContext(WebLocalFrame* frame, void WillReleaseScriptContext(v8::Local<v8::Context> context,
v8::Local<v8::Context> context,
int world_id) override { int world_id) override {
ASSERT_EQ(Frame(), frame);
release_notifications_.push_back( release_notifications_.push_back(
WTF::MakeUnique<Notification>(frame, context, world_id)); WTF::MakeUnique<Notification>(Frame(), context, world_id));
} }
}; };
......
...@@ -609,9 +609,7 @@ class BLINK_EXPORT WebFrameClient { ...@@ -609,9 +609,7 @@ class BLINK_EXPORT WebFrameClient {
int world_id) {} int world_id) {}
// WebKit is about to release its reference to a v8 context for a frame. // WebKit is about to release its reference to a v8 context for a frame.
virtual void WillReleaseScriptContext(WebLocalFrame*, virtual void WillReleaseScriptContext(v8::Local<v8::Context>, int world_id) {}
v8::Local<v8::Context>,
int world_id) {}
// Geometry notifications ---------------------------------------------- // Geometry notifications ----------------------------------------------
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment